Skip to content

Conversation

@eggerdj
Copy link
Contributor

@eggerdj eggerdj commented May 31, 2021

Summary

T2star test seems to fail.

Details and comments

There was a global variable SEED which has been removed and each test now uses np.random.seed(0).

@coruscating
Copy link
Collaborator

random.seed is no longer best practice and should be replaced by default_rng, according to https://towardsdatascience.com/stop-using-numpy-random-seed-581a9972805f

@coruscating coruscating merged commit 4b2fb38 into qiskit-community:main May 31, 2021
@yaelbh yaelbh mentioned this pull request Jun 1, 2021
@coruscating coruscating added this to the Release 0.1 milestone Jun 16, 2021
@eggerdj eggerdj deleted the t2star_test branch July 16, 2021 13:50
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
* * Added a seed for the T2Star experiment.

* * Switched to np.random.default_rng(0).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants