Skip to content

Conversation

@yaelbh
Copy link
Collaborator

@yaelbh yaelbh commented Jun 1, 2021

Identical to #69, but for T1 tests.
Are randomized benchmarking tests deterministic? Considering that the experiment itself involves randomizations. @ItamarGoldman @gadial @ShellyGarion

@ShellyGarion
Copy link
Contributor

The tests for RB @gadial @ItamarGoldman (as well as for QV @dekelmeirom) are divided into two parts:

  1. Test of the circuit generation - checks that the random circuits satisfies the conditions (the metadata is correct, in RB the circuit is equivalent to identity etc.). Here there is a fixed seed, see e.g.:
    https://github.com/Qiskit/qiskit-experiments/blob/d8cb33e1b8652458652a40011d5578179d186233/test/test_rb.py#L48

  2. Test of the fitters [WIP] - this is based on pre-generated data which is stored in json files. The code for generating the json files will also be provided as part of the test directory, and should include a fixed seed.

@yaelbh yaelbh merged commit 009af65 into qiskit-community:main Jun 7, 2021
@coruscating coruscating added this to the Release 0.1 milestone Jun 16, 2021
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants