Updated tutorials #501
Merged
Updated tutorials #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine-learning into primitives-qnn Merge latest changes from main
…ine-learning Merge latest changes in main
# Conflicts: # qiskit_machine_learning/neural_networks/__init__.py # test/connectors/test_torch_networks.py
into updated_tutorials � Conflicts: � qiskit_machine_learning/algorithms/classifiers/vqc.py � qiskit_machine_learning/neural_networks/sampler_qnn.py � releasenotes/notes/add-sampler-qnn-a093431afc1c5441.yaml � test/algorithms/classifiers/test_vqc.py � test/neural_networks/test_circuit_vs_sampler_qnn.py � test/neural_networks/test_sampler_qnn.py
adekusar-drl
requested review from
manoelmarques,
stefan-woerner and
woodsp-ibm
as code owners
woodsp-ibm
reviewed
Nov 2, 2022
Pull Request Test Coverage Report for Build 3390426063
💛 - Coveralls |
woodsp-ibm
approved these changes
Nov 4, 2022
oscar-wallis
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Add primitives branch to CI workflow * added pocs * init fixed * more init * Add qnns PoC * Establish qnn branch * Add fwd unit test * Refactor sampler qnn * Undo kernel changes * Start adding new type hint style * Move to neural_networks * Runnable tests * wip estimator qnn * wip * added estimator qnn * wip added unittests * added unittests * reno * fix reno * support estimator qnn in two_layer_qnn * Update typehints, refactor * Add new unittests, fix code * Add gradient unit test * Add torch tests * Remove unwanted change circuitQNN * Remove utils * Fix style, lint * Add VQC * Fix mypy * fix mypy * fix mypy * fix mypy * Restore workflow * Restore workflow * Update .github/workflows/main.yml * Fix mypy * Fix CI (hopefully) * Update requirements * Add sparse support * Fix style etc * Add type ignore * Fix style? * skip test if not sparse * Add type ignore * Fix mypy * Make keyword args * Make keyword args * Apply review comments * Fix tests, final refactor, add docstring * Add Sampler QNN * Update qiskit_machine_learning/algorithms/classifiers/vqc.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * updated * Apply reviews vqc * Apply reviews * Fix neko test * Fix spell check * make codes simpler with numpy * fix two_layer_qnn.py * wip unittests * update vqr * fix pylint * use kwargs * simplify reno code block * refactorings * unit tests, reno, spelling * vqr properties test * vectorize forward post processing * some refactorings * Update qiskit_machine_learning/algorithms/regressors/vqr.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Update qiskit_machine_learning/algorithms/regressors/vqr.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Update qiskit_machine_learning/algorithms/regressors/vqr.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * docstrings * added more unittests * Update releasenotes/notes/add-estimator-qnn-270b31662988bef9.yaml Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * code review * updated * fix lint * fix * fix spelling mistake * fix backward pass with no weight params * fix * Update qiskit_machine_learning/neural_networks/sampler_qnn.py * reflected comments * fix spell * Add try-catch * fix * add torch tests * convert two first tutorials * update 02a * update 05 * update 05 * update 09 * update 11 * code review * update qcnn * fix spell Co-authored-by: Manoel Marques <manoel.marques@ibm.com> Co-authored-by: Gian Gentinetta <gian.gentinetta@gmx.ch> Co-authored-by: ElePT <epenatap@gmail.com> Co-authored-by: ElePT <57907331+ElePT@users.noreply.github.com> Co-authored-by: a-matsuo <MATSUOA@jp.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the QNN related tutorials to the new implementations,
SamplerQNNandEstimatorQNNaccordingly. There are no intentions to improve the tutorials in the PR, but rather update them. Some features, e.g. sampling and sparse support are excluded as they are either not yet available or not demonstrable on the reference implementation.Details and comments
Updated:
The effective dimension tutorial is updated in a separate PR: #507
To be merged after #436, #470.