Skip to content

Conversation

@adekusar-drl
Copy link
Collaborator

@adekusar-drl adekusar-drl commented Nov 1, 2022

Summary

This PR updates/adds:

  • EffectiveDimension class
  • New unit tests that work on SamplerQNN and EstimatorQNN
  • The Effective Dimension tutorial

To be merged after #436

@adekusar-drl adekusar-drl added this to the 0.5.0 milestone Nov 1, 2022
@adekusar-drl adekusar-drl mentioned this pull request Nov 1, 2022
6 tasks
@adekusar-drl adekusar-drl added the on hold 🛑 Can not fix yet label Nov 1, 2022
@coveralls
Copy link

coveralls commented Nov 1, 2022

Pull Request Test Coverage Report for Build 3377864852

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 88.853%

Files with Coverage Reduction New Missed Lines %
qiskit_machine_learning/datasets/gaussian.py 3 37.11%
Totals Coverage Status
Change from base Build 3377776279: -0.07%
Covered Lines: 3539
Relevant Lines: 3983

💛 - Coveralls

 into update_ed

� Conflicts:
�	qiskit_machine_learning/neural_networks/sampler_qnn.py
�	releasenotes/notes/add-sampler-qnn-a093431afc1c5441.yaml
@adekusar-drl adekusar-drl removed the on hold 🛑 Can not fix yet label Nov 2, 2022
@adekusar-drl adekusar-drl changed the title [WIP] Update EffectiveDimension [Update EffectiveDimension Nov 2, 2022
@adekusar-drl adekusar-drl changed the title [Update EffectiveDimension Update EffectiveDimension Nov 2, 2022
@adekusar-drl adekusar-drl marked this pull request as ready for review November 2, 2022 13:20
@adekusar-drl adekusar-drl merged commit 941bbea into qiskit-community:main Nov 2, 2022
@adekusar-drl adekusar-drl deleted the update_ed branch November 2, 2022 21:37
oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
* Add primitives branch to CI workflow

* added pocs

* init fixed

* more init

* Add qnns PoC

* Establish qnn branch

* Add fwd unit test

* Refactor sampler qnn

* Undo kernel changes

* Start adding new type hint style

* Move to neural_networks

* Runnable tests

* Update typehints, refactor

* Add new unittests, fix code

* Add gradient unit test

* Add torch tests

* Remove unwanted change circuitQNN

* Remove utils

* Fix style, lint

* Add VQC

* Fix mypy

* fix mypy

* fix mypy

* fix mypy

* Restore workflow

* Restore workflow

* Update .github/workflows/main.yml

* Fix mypy

* Fix CI (hopefully)

* Update requirements

* Add sparse support

* Fix style etc

* Add type ignore

* Fix style?

* skip test if not sparse

* Add type ignore

* Fix mypy

* Make keyword args

* Make keyword args

* Apply review comments

* Fix tests, final refactor, add docstring

* Add Sampler QNN

* Update qiskit_machine_learning/algorithms/classifiers/vqc.py

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>

* Apply reviews vqc

* Apply reviews

* Fix neko test

* Fix spell check

* Update qiskit_machine_learning/neural_networks/sampler_qnn.py

* Add try-catch

* Add deprecations

* Update tests

* Fix tests

* Filter warnings

* Fix filter

* fix black, pylint

* update docstring

* pulled the method up, modern type hints

* fix spell

* update ed

* update comment

* update test

* update tutorial

* black

* remove circuit qnn

Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
Co-authored-by: Gian Gentinetta <gian.gentinetta@gmx.ch>
Co-authored-by: ElePT <epenatap@gmail.com>
Co-authored-by: ElePT <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants