Skip to content

Implementation AquaPath#447

Merged
kraemr merged 4 commits intomasterfrom
fix/438
Sep 29, 2025
Merged

Implementation AquaPath#447
kraemr merged 4 commits intomasterfrom
fix/438

Conversation

@Anatomik5
Copy link
Copy Markdown
Contributor

@Anatomik5 Anatomik5 commented Jun 30, 2025

fix #60

@Anatomik5 Anatomik5 force-pushed the fix/438 branch 3 times, most recently from e5503f9 to bbbf037 Compare July 4, 2025 14:02
@Anatomik5 Anatomik5 force-pushed the fix/438 branch 2 times, most recently from 20150af to 3394d32 Compare August 7, 2025 15:16
@Anatomik5 Anatomik5 force-pushed the fix/438 branch 2 times, most recently from 14dd351 to 36c48a9 Compare September 15, 2025 14:55
@Anatomik5 Anatomik5 force-pushed the fix/438 branch 3 times, most recently from b9a1e71 to 4dbfad2 Compare September 24, 2025 15:05
@Anatomik5 Anatomik5 marked this pull request as ready for review September 24, 2025 15:08
@Anatomik5 Anatomik5 requested a review from kraemr September 24, 2025 15:08
Copy link
Copy Markdown
Collaborator

@kraemr kraemr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all leftover comments and implement what i left as comments then it can probably get merged next week

Comment thread ethercat-hal/src/pdo/el40xx.rs
Comment thread server/src/ethercat/setup.rs
Comment thread server/src/machines/aquapath1/act.rs Outdated
Comment thread server/src/machines/aquapath1/controller.rs Outdated
Comment thread server/src/machines/aquapath1/flow_controller.rs Outdated
Comment thread server/src/machines/aquapath1/flow_controller.rs Outdated
Comment thread server/src/machines/aquapath1/new.rs Outdated
Comment thread server/src/machines/aquapath1/temperature_controller.rs Outdated
Comment thread server/src/machines/mod.rs Outdated
Copy link
Copy Markdown
Collaborator

@kraemr kraemr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kraemr kraemr merged commit b03cedb into master Sep 29, 2025
4 checks passed
@kraemr kraemr deleted the fix/438 branch September 29, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add machine Aquapath V1

3 participants