Fix images in the manual are not loading#601
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes image loading issues in manual documentation displayed on the HMI-Panel by updating Vite configuration and standardizing image paths throughout markdown files.
- Adds
publicDirconfiguration to Vite renderer setup to properly serve static assets - Updates all image references from relative
src/assets/paths to standardizedimages/manuals/paths - Ensures consistent image path structure across winder and mock machine documentation
Reviewed Changes
Copilot reviewed 3 out of 51 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| electron/vite.renderer.config.ts | Configures Vite to serve public directory for static assets |
| electron/src/assets/markdown/winder/manual.md | Updates all image paths from src/assets/ to images/manuals/winder/ |
| electron/src/assets/markdown/mock/manual.md | Updates single image path from src/assets/ to images/manuals/mock/ |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that the images are not loading in the manual on the HMI-Panel
Closes #598