Skip to content

604 manuals have two scroll bars#641

Merged
1cedsoda merged 4 commits intomasterfrom
604-manuals-have-two-scroll-bars
Sep 1, 2025
Merged

604 manuals have two scroll bars#641
1cedsoda merged 4 commits intomasterfrom
604-manuals-have-two-scroll-bars

Conversation

@TheBest6337
Copy link
Copy Markdown
Member

This pull request improves the usability and responsiveness of the Markdown Table of Contents (TOC) component in the Electron app. The main changes focus on better active heading detection, smoother scrolling and highlighting behavior, and improved layout stability. The most important updates are grouped below.

TOC Active Heading Detection & Highlighting

  • Improved the logic for detecting which headings are active in the viewport, making it more accurate and robust, including better fallback behavior when no headings are visible.
  • Added an effect to automatically scroll the TOC so the active heading button remains comfortably in view within its scroll container.

Layout and UI Enhancements

  • Updated TOC button styling to use consistent right padding regardless of active state, preventing layout shifts.
  • Added a data-toc-id attribute to TOC buttons to support precise scrolling and highlighting.
  • Hid scrollbars for the TOC container across browsers for a cleaner look.

@TheBest6337 TheBest6337 linked an issue Aug 28, 2025 that may be closed by this pull request
@TheBest6337 TheBest6337 self-assigned this Aug 28, 2025
@TheBest6337 TheBest6337 force-pushed the 604-manuals-have-two-scroll-bars branch from 6f017b3 to 273d695 Compare August 28, 2025 19:12
@TheBest6337 TheBest6337 requested a review from 1cedsoda August 28, 2025 19:13
Copy link
Copy Markdown
Contributor

@1cedsoda 1cedsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@1cedsoda 1cedsoda merged commit b820a43 into master Sep 1, 2025
4 checks passed
@1cedsoda 1cedsoda deleted the 604-manuals-have-two-scroll-bars branch September 1, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manuals have two scroll bars

2 participants