Skip to content

666 implement laserv2#731

Merged
kraemr merged 8 commits intomasterfrom
666-implement-laserv2
Sep 16, 2025
Merged

666 implement laserv2#731
kraemr merged 8 commits intomasterfrom
666-implement-laserv2

Conversation

@Snacj
Copy link
Copy Markdown
Collaborator

@Snacj Snacj commented Sep 16, 2025

fix #666

@Snacj Snacj requested a review from kraemr September 16, 2025 13:20
Copilot AI review requested due to automatic review settings September 16, 2025 13:21
@Snacj Snacj added the m/laser1 Machine DRE label Sep 16, 2025
@Snacj Snacj linked an issue Sep 16, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for laser v2 devices that provide 2-axis (X and Y) measurements in addition to the existing diameter measurement. The changes extend the laser system to handle optional X and Y axis data from the hardware and display it in the frontend.

  • Extends laser data structures to include optional X and Y axis measurements
  • Updates the frontend to display X and Y values when available from 2-axis laser devices
  • Maintains backward compatibility with existing single-axis laser devices

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
server/src/serial/devices/laser/mod.rs Adds X/Y axis fields to laser data structures and parsing logic
server/src/machines/laser/mod.rs Updates live values emission to include X/Y axis data
server/src/machines/laser/api.rs Extends API event structure with optional X/Y fields
electron/src/machines/laser/laser1/useLaser1.ts Exposes X/Y values to laser hook consumers
electron/src/machines/laser/laser1/laser1Namespace.ts Adds X/Y time series handling and nullable schema validation
electron/src/machines/laser/laser1/Laser1Graph.tsx Renders separate graphs for X and Y axis measurements
electron/src/machines/laser/laser1/Laser1ControlPage.tsx Displays current X/Y values in the control interface

Comment thread server/src/serial/devices/laser/mod.rs Outdated
Comment thread electron/src/machines/laser/laser1/Laser1Graph.tsx Outdated
Comment thread electron/src/machines/laser/laser1/Laser1Graph.tsx Outdated
@Snacj Snacj requested a review from Copilot September 16, 2025 14:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Comment thread server/src/serial/devices/laser/mod.rs
Comment thread electron/src/machines/laser/DiameterVisualisation.tsx
@Snacj Snacj force-pushed the 666-implement-laserv2 branch from 5a0e1e9 to 33d1050 Compare September 16, 2025 14:40
Copy link
Copy Markdown
Collaborator

@kraemr kraemr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread electron/src/machines/laser/laser1/Laser1Graph.tsx Outdated
@kraemr kraemr force-pushed the 666-implement-laserv2 branch from 33d1050 to 0c02fc1 Compare September 16, 2025 14:52
@kraemr kraemr merged commit 936e54f into master Sep 16, 2025
4 checks passed
@kraemr kraemr deleted the 666-implement-laserv2 branch September 16, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

m/laser1 Machine DRE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement LaserV2

3 participants