Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for laser v2 devices that provide 2-axis (X and Y) measurements in addition to the existing diameter measurement. The changes extend the laser system to handle optional X and Y axis data from the hardware and display it in the frontend.
- Extends laser data structures to include optional X and Y axis measurements
- Updates the frontend to display X and Y values when available from 2-axis laser devices
- Maintains backward compatibility with existing single-axis laser devices
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/serial/devices/laser/mod.rs | Adds X/Y axis fields to laser data structures and parsing logic |
| server/src/machines/laser/mod.rs | Updates live values emission to include X/Y axis data |
| server/src/machines/laser/api.rs | Extends API event structure with optional X/Y fields |
| electron/src/machines/laser/laser1/useLaser1.ts | Exposes X/Y values to laser hook consumers |
| electron/src/machines/laser/laser1/laser1Namespace.ts | Adds X/Y time series handling and nullable schema validation |
| electron/src/machines/laser/laser1/Laser1Graph.tsx | Renders separate graphs for X and Y axis measurements |
| electron/src/machines/laser/laser1/Laser1ControlPage.tsx | Displays current X/Y values in the control interface |
5a0e1e9 to
33d1050
Compare
kraemr
approved these changes
Sep 16, 2025
33d1050 to
0c02fc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #666