818 smooth fluctuating temperature extruder#826
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #818 by implementing separate PID settings for three temperature zones (front, middle, back) in the extruder control system. Previously, temperature PID settings were managed as a single unit, which likely contributed to fluctuating temperature behavior.
Key Changes:
- Refactored temperature PID settings from a single
PidSettingsstructure to zone-specificTemperaturePidStateswith individual settings for front, middle, and back zones - Added new mutation handler
SetTemperaturePidSettingsto configure PID parameters per zone - Updated UI to display three separate temperature PID control cards with zone-specific parameters
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/machines/extruder1/api.rs | Added TemperaturePid and TemperaturePidStates structs, and new mutation variant for zone-specific temperature PID settings |
| server/src/machines/extruder1/emit.rs | Updated state emission to populate zone-specific temperature PID values from controllers |
| server/src/machines/extruder1/mock/new.rs | Updated mock initialization with zone-specific temperature PID structures |
| server/src/machines/extruder1/mock/mock_emit.rs | Added configure_temperature_pid method to handle zone-specific PID configuration in mock |
| server/src/machines/extruder1/mock/api.rs | Added mutation handler for SetTemperaturePidSettings in mock implementation |
| electron/src/machines/extruder/extruder2/extruder2Namespace.ts | Updated schema to reflect zone-specific temperature PID structure |
| electron/src/machines/extruder/extruder2/useExtruder.ts | Added setTemperaturePidValue function and mutation request for zone-specific PID updates |
| electron/src/machines/extruder/extruder2/Extruder2Settings.tsx | Added three temperature PID control cards for front, middle, and back zones |
Files not reviewed (1)
- electron/package-lock.json: Language not supported
9f891bd to
b905602
Compare
kraemr
approved these changes
Oct 20, 2025
b905602 to
0dba0f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #818