Skip to content

818 smooth fluctuating temperature extruder#826

Merged
kraemr merged 8 commits intomasterfrom
818-smooth-fluctuating-temperature-extruder
Oct 20, 2025
Merged

818 smooth fluctuating temperature extruder#826
kraemr merged 8 commits intomasterfrom
818-smooth-fluctuating-temperature-extruder

Conversation

@Snacj
Copy link
Copy Markdown
Collaborator

@Snacj Snacj commented Oct 17, 2025

fix #818

Copilot AI review requested due to automatic review settings October 17, 2025 11:21
@Snacj Snacj added the m/extruder2 Machine Extruder 2 label Oct 17, 2025
@Snacj Snacj linked an issue Oct 17, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #818 by implementing separate PID settings for three temperature zones (front, middle, back) in the extruder control system. Previously, temperature PID settings were managed as a single unit, which likely contributed to fluctuating temperature behavior.

Key Changes:

  • Refactored temperature PID settings from a single PidSettings structure to zone-specific TemperaturePidStates with individual settings for front, middle, and back zones
  • Added new mutation handler SetTemperaturePidSettings to configure PID parameters per zone
  • Updated UI to display three separate temperature PID control cards with zone-specific parameters

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
server/src/machines/extruder1/api.rs Added TemperaturePid and TemperaturePidStates structs, and new mutation variant for zone-specific temperature PID settings
server/src/machines/extruder1/emit.rs Updated state emission to populate zone-specific temperature PID values from controllers
server/src/machines/extruder1/mock/new.rs Updated mock initialization with zone-specific temperature PID structures
server/src/machines/extruder1/mock/mock_emit.rs Added configure_temperature_pid method to handle zone-specific PID configuration in mock
server/src/machines/extruder1/mock/api.rs Added mutation handler for SetTemperaturePidSettings in mock implementation
electron/src/machines/extruder/extruder2/extruder2Namespace.ts Updated schema to reflect zone-specific temperature PID structure
electron/src/machines/extruder/extruder2/useExtruder.ts Added setTemperaturePidValue function and mutation request for zone-specific PID updates
electron/src/machines/extruder/extruder2/Extruder2Settings.tsx Added three temperature PID control cards for front, middle, and back zones
Files not reviewed (1)
  • electron/package-lock.json: Language not supported

Comment thread server/src/machines/extruder1/mock/new.rs Outdated
Comment thread server/src/machines/extruder1/mock/new.rs Outdated
Comment thread electron/src/machines/extruder/extruder2/useExtruder.ts Outdated
Comment thread electron/src/machines/extruder/extruder2/useExtruder.ts Outdated
@kraemr kraemr force-pushed the 818-smooth-fluctuating-temperature-extruder branch 2 times, most recently from 9f891bd to b905602 Compare October 20, 2025 14:12
@kraemr kraemr force-pushed the 818-smooth-fluctuating-temperature-extruder branch from b905602 to 0dba0f2 Compare October 20, 2025 16:12
@kraemr kraemr merged commit c598e3f into master Oct 20, 2025
4 checks passed
@kraemr kraemr deleted the 818-smooth-fluctuating-temperature-extruder branch October 20, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

m/extruder2 Machine Extruder 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Smooth Fluctuating temperature Extruder

3 participants