Skip to content

769 add an alert or warning in the frontend for filament out of spec#849

Merged
kraemr merged 15 commits intomasterfrom
769-add-an-alert-or-warning-in-the-frontend-for-filament-out-of-spec
Dec 18, 2025
Merged

769 add an alert or warning in the frontend for filament out of spec#849
kraemr merged 15 commits intomasterfrom
769-add-an-alert-or-warning-in-the-frontend-for-filament-out-of-spec

Conversation

@Snacj
Copy link
Copy Markdown
Collaborator

@Snacj Snacj commented Oct 24, 2025

fix #769

Copilot AI review requested due to automatic review settings October 24, 2025 09:57
@Snacj Snacj added the m/laser1 Machine DRE label Oct 24, 2025
@Snacj Snacj linked an issue Oct 24, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a filament out-of-tolerance warning system for the laser machine. It adds tolerance checking logic in the backend and displays warnings in the frontend when the laser diameter falls outside acceptable tolerances.

  • Adds tolerance tracking and validation logic to the laser machine backend
  • Creates a global toast notification system for out-of-tolerance warnings
  • Adds a new settings page to configure auto-stop behavior on tolerance violations

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
server/src/machines/laser/new.rs Initializes new tolerance-related fields in laser machine state
server/src/machines/laser/mod.rs Implements tolerance calculation logic and state tracking
server/src/machines/laser/api.rs Extends API with tolerance state fields and auto-stop mutation
server/src/machines/laser/act.rs Adds state emission on tolerance changes
electron/src/setup/GlobalLaserToastManager.tsx Creates global toast manager for displaying out-of-tolerance warnings
electron/src/routes/routes.tsx Adds new settings page route
electron/src/machines/laser/laser1/useLaser1.ts Adds auto-stop toggle functionality to hook
electron/src/machines/laser/laser1/laser1Namespace.ts Updates state schema with tolerance fields
electron/src/machines/laser/laser1/Laser1Settings.tsx New settings page component with auto-stop checkbox
electron/src/machines/laser/laser1/Laser1PresetsPage.tsx Adds auto-stop to preset data
electron/src/machines/laser/laser1/Laser1Page.tsx Adds settings navigation link
electron/src/machines/laser/laser1/Laser1ControlPage.tsx Removes trailing variable declarations
electron/src/components/ui/checkbox-selection.tsx New checkbox component for settings
electron/src/App.tsx Integrates global toast manager

Comment thread machines/src/laser/mod.rs
Comment thread server/src/machines/laser/mod.rs Outdated
Comment thread electron/src/App.tsx Outdated
Comment thread server/src/machines/laser/act.rs Outdated
Comment thread electron/src/setup/GlobalLaserToastManager.tsx Outdated
@Snacj
Copy link
Copy Markdown
Collaborator Author

Snacj commented Oct 24, 2025

@kraemr do NOT include in release until laser - winder connection is fully established and tested. It is needed to include the option to disable the winder automatically if the laser is out of tolerance.

@kraemr kraemr marked this pull request as draft October 31, 2025 09:44
@Snacj Snacj force-pushed the 769-add-an-alert-or-warning-in-the-frontend-for-filament-out-of-spec branch from fd47614 to 7f47fee Compare December 16, 2025 12:29
@Snacj Snacj requested a review from Copilot December 16, 2025 16:32
@Snacj
Copy link
Copy Markdown
Collaborator Author

Snacj commented Dec 16, 2025

I implemented and updated the Laser Alert if its out of tolerance it the backend. This can be merged. I will make a new Issue to determine machine stops via machine connections

@Snacj Snacj force-pushed the 769-add-an-alert-or-warning-in-the-frontend-for-filament-out-of-spec branch from 369c8f5 to a1eea1b Compare December 16, 2025 16:37
@Snacj Snacj marked this pull request as ready for review December 16, 2025 16:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.

Files not reviewed (1)
  • electron/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

server/src/machines/laser/act.rs:1

  • The documentation incorrectly states '20 milliseconds' and '60 FPS', but the implementation uses 33ms (1/30 seconds) for 30 FPS. The documentation should be updated to match the actual implementation.
use super::LaserMachine;

Comment thread server/src/machines/laser/act.rs
Comment thread machines/src/laser/mod.rs
Comment thread machines/src/laser/mod.rs
Comment thread electron/src/setup/GlobalLaserToastManager.tsx
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kraemr kraemr force-pushed the 769-add-an-alert-or-warning-in-the-frontend-for-filament-out-of-spec branch from a1eea1b to da69ad1 Compare December 18, 2025 10:22
@kraemr kraemr self-requested a review December 18, 2025 11:00
@kraemr kraemr merged commit 59cf2ce into master Dec 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

m/laser1 Machine DRE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an Alert or Warning in the frontend for filament out of spec

3 participants