Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a filament out-of-tolerance warning system for the laser machine. It adds tolerance checking logic in the backend and displays warnings in the frontend when the laser diameter falls outside acceptable tolerances.
- Adds tolerance tracking and validation logic to the laser machine backend
- Creates a global toast notification system for out-of-tolerance warnings
- Adds a new settings page to configure auto-stop behavior on tolerance violations
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/machines/laser/new.rs | Initializes new tolerance-related fields in laser machine state |
| server/src/machines/laser/mod.rs | Implements tolerance calculation logic and state tracking |
| server/src/machines/laser/api.rs | Extends API with tolerance state fields and auto-stop mutation |
| server/src/machines/laser/act.rs | Adds state emission on tolerance changes |
| electron/src/setup/GlobalLaserToastManager.tsx | Creates global toast manager for displaying out-of-tolerance warnings |
| electron/src/routes/routes.tsx | Adds new settings page route |
| electron/src/machines/laser/laser1/useLaser1.ts | Adds auto-stop toggle functionality to hook |
| electron/src/machines/laser/laser1/laser1Namespace.ts | Updates state schema with tolerance fields |
| electron/src/machines/laser/laser1/Laser1Settings.tsx | New settings page component with auto-stop checkbox |
| electron/src/machines/laser/laser1/Laser1PresetsPage.tsx | Adds auto-stop to preset data |
| electron/src/machines/laser/laser1/Laser1Page.tsx | Adds settings navigation link |
| electron/src/machines/laser/laser1/Laser1ControlPage.tsx | Removes trailing variable declarations |
| electron/src/components/ui/checkbox-selection.tsx | New checkbox component for settings |
| electron/src/App.tsx | Integrates global toast manager |
|
@kraemr do NOT include in release until laser - winder connection is fully established and tested. It is needed to include the option to disable the winder automatically if the laser is out of tolerance. |
fd47614 to
7f47fee
Compare
|
I implemented and updated the Laser Alert if its out of tolerance it the backend. This can be merged. I will make a new Issue to determine machine stops via machine connections |
369c8f5 to
a1eea1b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.
Files not reviewed (1)
- electron/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
server/src/machines/laser/act.rs:1
- The documentation incorrectly states '20 milliseconds' and '60 FPS', but the implementation uses 33ms (1/30 seconds) for 30 FPS. The documentation should be updated to match the actual implementation.
use super::LaserMachine;
a1eea1b to
da69ad1
Compare
fix #769