699 add min and max diameter on laser page#885
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new MinMaxValue component for displaying min/max values from time series data with configurable timeframes, and integrates it into the Laser1ControlPage to show diameter and roundness ranges.
- Adds
MinMaxValuecomponent with support for controlled/uncontrolled timeframe selection - Integrates min/max display for diameter and roundness measurements in Laser1ControlPage
- Implements shared timeframe selector for synchronized viewing across multiple metrics
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| electron/src/control/MinMaxValue.tsx | New component for displaying min/max values from time series data with timeframe selector and custom zero-value filtering logic |
| electron/src/machines/laser/laser1/Laser1ControlPage.tsx | Integrates MinMaxValue component with conditional rendering for 2-axis vs single-axis lasers and shared timeframe selector |
Comments suppressed due to low confidence (1)
electron/src/control/MinMaxValue.tsx:11
- Unused import getSeriesMinMax.
import { getSeriesMinMax } from "@/lib/timeseries";
TheBest6337
force-pushed
the
699-add-min-and-max-diameter-on-laser-page2
branch
from
e5d2486 to
bc9baa6
Compare
kraemr
force-pushed
the
699-add-min-and-max-diameter-on-laser-page2
branch
from
bc9baa6 to
63ab978
Compare
…or diameter range display
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
TheBest6337
force-pushed
the
699-add-min-and-max-diameter-on-laser-page2
branch
from
63ab978 to
4025a68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
MinMaxValuecomponent for displaying minimum and maximum values from a timeseries, and integrates it into the laser control page to improve the display of diameter and roundness ranges. It also centralizes the timeframe selector for these statistics, enhancing usability and consistency.New component and shared timeframe logic:
MinMaxValueReact component inMinMaxValue.tsxthat calculates and displays the min/max values for a given timeseries over a selectable timeframe, with support for custom rendering and units.TIMEFRAME_OPTIONSfor consistent timeframe selectionIntegration into the laser control page:
Laser1ControlPage.tsxto use the newMinMaxValuecomponent for displaying diameter and roundness ranges, including logic to support both single-axis and two-axis lasers. [1] [2]