[develop] Fix: Tutorial build issues — missing imports, packages, handlers, and CLI guidance#20
[develop] Fix: Tutorial build issues — missing imports, packages, handlers, and CLI guidance#20qiutongMS wants to merge 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Summary: I reviewed the latest PR diff and the full content of all 21 modified files. I found 2 blocking issues: one incorrect Copilot plugin install identifier, and one Win2D tutorial section that still contradicts itself about whether the sample lives in MainWindow or MainPage files. Must-fix issues:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Summary: I reviewed the latest PR diff and the full content of each modified file. I found several blocking issues where the updated docs either use invalid commands or leave readers with contradictory/incorrect instructions. Must-fix issues:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Review Result: CHANGES_REQUESTEDSummaryThe PR correctly adds missing using directives, TIP callouts for command-line build, and a meaningful lambda syntax-error fix in windows-hello-auth-service.md. One must-fix issue found: the winapp package command in ai-build.md references a win-x64 subdirectory created only by dotnet publish -r win-x64, NOT by the preceding dotnet build -p:Platform=x64 -- readers will hit a path-not-found error. Must-Fix Issues
Suggestions
|
|
Overall assessment: the PR is mostly solid, but one change introduces a broken packaging workflow in Must-fix:
Please either:
|
…usings) Revert changes that experienced C# developers can self-diagnose: - Remove all -p:Platform=x64 CLI tips (standard WinUI knowledge) - Remove incidental using additions (System.*, async plumbing) - Remove self-diagnosable package notes (Newtonsoft.Json) Keep only real doc gaps: topic-related imports, typo fixes, missing handler/control definitions, and content corrections. Reduces PR scope from 21 files to 11 files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
All System.* imports are self-diagnosable from compiler errors. Only keep third-party package usings (SqlClient, MongoDB, MySQL) and non-System WinRT API usings (Windows.Storage). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove TIP/NOTE blocks that add text to explain things readers should figure out from the code itself: - Camera: remove TIP (snippet repo should be fixed directly) - Pickers: remove TextBlock prose (code context is sufficient) - Win2D: remove NOTE about file organization (code fix speaks for itself) Also removes camera page from PR (no code-level changes remain). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Completeness check
Skipped Findings