Add github.submit-to-upstream config option #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Detect generated files via .gitattributes linguist-generated patterns, @generated/@partially-generated tags in file content, and default patterns (lock files, .min.js, etc.) - Show "X sig" counter next to +/- counts with explanatory tooltip - Label generated files in diff header with "Generated" badge - Auto-collapse generated files in the diff view - Fix: Move fileGeneratedStatus into waitForAll preload block to prevent re-rendering issues (per TODO T122242329) - Fix: Calculate SLOC using per-file diff lines instead of entire file content for accurate significant line counts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary: Test Plan:
Add `sl pr get` CLI command to pull entire PR stacks from GitHub by parsing the Sapling stack footer in PR descriptions. The command supports --goto to checkout the target commit and --downstack to only fetch from trunk to the target PR. Add ISL PR Dashboard in the left drawer showing all open PRs from the last 30 days, grouped by stacks. Each stack shows PRs in order with one-click "Pull" buttons to fetch stacks via `sl pr get`. Features: - sl pr get <PR> - Import full stack based on PR body footer - sl pr get <PR> --goto - Import and checkout target - sl pr get <PR> --downstack - Only fetch trunk→target - PR Dashboard shows all open PRs grouped by stacks - Keyboard shortcut Cmd+, to toggle left drawer Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add a new config option `github.submit-to-upstream` (default: true) that controls whether `sl pr submit` creates PRs against the upstream repository when working from a fork, or against the fork itself. When set to false, PRs will be created on your fork instead of the upstream repository. This is useful when you want to create PRs within your own fork for testing or other purposes. Usage: [github] submit-to-upstream = false Or via command line: sl --config github.submit-to-upstream=false pr submit Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new config option
github.submit-to-upstream(default: true) thatcontrols whether
sl pr submitcreates PRs against the upstream repositorywhen working from a fork, or against the fork itself.
When set to false, PRs will be created on your fork instead of the upstream
repository. This is useful when you want to create PRs within your own fork
for testing or other purposes.
Usage:
[github]
submit-to-upstream = false
Or via command line:
sl --config github.submit-to-upstream=false pr submit
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Stack created with Sapling. Best reviewed with ReviewStack.