Fix tmux theme watcher pane closing immediately#72
Merged
peterjaap merged 3 commits intoApr 7, 2026
Merged
Conversation
Use cd + npm run watch instead of npm --prefix, which only sets the package lookup dir but not the working directory for the spawned process. Create the tmux session with a shell first and set remain-on-exit before sending the watch command, so errors stay visible if the process exits. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace remain-on-exit with a shell wrapper that pauses on error with a user-friendly message. Ctrl-C closes the pane normally, errors stay visible until the user presses Enter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Changed it a bit since remain open was too aggressive. I could not close tmux with ctrl+c. Now it is possible to shut it down while it stays open on errors. |
peterjaap
added a commit
that referenced
this pull request
Apr 7, 2026
* Detect any theme with npm watch script, not just Hyvä - Walk full theme tree under app/design/frontend/ for package.json files with a "watch" script instead of hardcoding web/tailwind/ - Prompt user to select when multiple themes are found - Works for Hyvä, Luma+Tailwind, or any custom theme setup * Fix tmux theme watcher pane closing immediately (#72) * Fix tmux theme watcher pane closing immediately Use cd + npm run watch instead of npm --prefix, which only sets the package lookup dir but not the working directory for the spawned process. Create the tmux session with a shell first and set remain-on-exit before sending the watch command, so errors stay visible if the process exits. * Restore npm --prefix for theme watcher command * Show error message on npm watch failure instead of closing pane Replace remain-on-exit with a shell wrapper that pauses on error with a user-friendly message. Ctrl-C closes the pane normally, errors stay visible until the user presses Enter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create the tmux session with a shell first and set remain-on-exit before sending the watch command, so errors stay visible if the process exits.