Timestamptz fix #62
Merged
Timestamptz fix #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in v5.7.5 (May 10, 2025) and we need it to easily test different timezones. Signed-off-by: Daniel Vérité <dverite@gmail.com>
Signed-off-by: Daniel Vérité <dverite@gmail.com>
In order to be timezone-agnostic, we submit partition bounds without
timezone offsets, like:
VALUES FROM ('YYYY-MM-DD 00:00:00') TO ('YYYY-MM-DD 00:00:00')
The time zone of the session is automatically applied by Postgres.
When reading back these values, we get for instance
YYYY-MM-DD 00:00:00+02
if the current time zone offset is +02.
If we rotate this timestamp locally to UTC and resubmit it without the
offset, it is now incorrect (unless the server happens to be
configured in UTC).
The fix consists of ignoring the offset when reading the current
bounds, to be consistently timezone-agnostic. The offset always
corresponds implicitly to the time zone of the SQL session, and
must not be forced in the value of the timestamp.
The SQL time zone can be changed dynamically with the PGTZ environment
variable if desired.
Signed-off-by: Daniel Vérité <dverite@gmail.com>
Signed-off-by: Daniel Vérité <dverite@gmail.com>
qfritz
reviewed
Jul 1, 2025
Collaborator
Author
|
#storage |
qfritz
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code has an issue with timestamptz partition keys when the time zone is not UTC.
The first provisioning works as expected, but when reading back the partition definitions,
the expected boundaries differ from what is read from the database.
This is essentially due to rotating locally the values to UTC instead of ignoring the timezone offset.
Additionally add support for the PGTZ env variable (updated driver jackc/pgx) and add a test
with a timestamptz partition key and a non-UTC time zone.