React 19 and The New Architecture support.#373
Merged
Conversation
suriksarkisyan
approved these changes
Aug 27, 2025
| ReactNativeSdk_targetSdkVersion=34 | ||
| ReactNativeSdk_compileSdkVersion=35 | ||
| ReactNativeSdk_ndkVersion=27.1.12297006 | ||
| # newArchEnabled=true No newline at end of file |
Contributor
There was a problem hiding this comment.
Should we leave this here?
| import com.facebook.react.module.model.ReactModuleInfoProvider | ||
| import com.reactlibrary.QonversionModule | ||
|
|
||
| class ReactNativeSdkPackage : BaseReactPackage() { |
Contributor
There was a problem hiding this comment.
I think will be better to rename this file and associate it with Qonversion
| * Returns the name of the main component registered from JavaScript. This is used to schedule | ||
| * rendering of the component. | ||
| */ | ||
| override fun getMainComponentName(): String = "ReactNativeSdkExample" |
Contributor
There was a problem hiding this comment.
And I prefer to rename here as well and associate it with Q
| @@ -1,3 +1,3 @@ | |||
| <resources> | |||
| <string name="app_name">RN Qonversion</string> | |||
| <string name="app_name">ReactNativeSdkExample</string> | |||
| BuildableName = "exampleTests.xctest" | ||
| BlueprintName = "exampleTests" | ||
| ReferencedContainer = "container:example.xcodeproj"> | ||
| BuildableName = "ReactNativeExampleTests.xctest" |
Contributor
There was a problem hiding this comment.
Let's remove test target
| "android": "react-native run-android", | ||
| "reIos": "yarn cleanIos && yarn ios", | ||
| "ios": "react-native run-ios", | ||
| "pods": "cd ios && RCT_NEW_ARCH_ENABLED=1 bundle exec pod install && cd ..", |
Contributor
There was a problem hiding this comment.
RCT_NEW_ARCH_ENABLED=1 is not required because it's already set in the podfile. But we can leave this here anyway.
|
|
||
| #pragma mark - Private | ||
|
|
||
| NSDictionary *convertPromoOfferDetailsToDictionary(JS::NativeQonversionModule::QPromoOfferDetails &promoOffer) { |
Contributor
There was a problem hiding this comment.
I think will be better to move this logic to the swift class
| class QonversionEventHandler: QonversionEventListener { | ||
| weak var delegate: QonversionEventDelegate? | ||
|
|
||
| init(delegate: QonversionEventDelegate?) { |
Contributor
There was a problem hiding this comment.
Looks like we don't need delegate here
| } | ||
|
|
||
| private func handleResult(result: [String: Any]?, error: SandwichError?, resolve: RCTPromiseResolveBlock, reject: RCTPromiseRejectBlock) { | ||
| if let error = error { |
Contributor
There was a problem hiding this comment.
Suggested change
| if let error = error { | |
| if let error { |
| reject(error.code, error.details, nil) | ||
| return | ||
| } | ||
| if let result = result { |
Contributor
There was a problem hiding this comment.
Suggested change
| if let result = result { | |
| if let result { |
suriksarkisyan
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.