add record based support for quickbooks#211
Merged
nickmazurenko merged 3 commits intodevelopfrom Feb 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds record-based (table/record CRUD) support to the QuickBooks app, including schema/expressions metadata and iterator-based search, plus accompanying i18n and tests.
Changes:
- Introduces QuickBooks record-based helpers for table listing, record typing, search (iterator), and batch create/update/delete.
- Adds QuickBooks search expressions + search options (orderBy) and wires record-based functions into the app export.
- Adds extensive unit/integration tests and updates i18n typings/translations to include expression metadata.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| ts/src/apps/quickbooks/index.ts | Wires the new record-based interface into the QuickBooks app export. |
| ts/src/apps/quickbooks/helpers/record-based/index.ts | Barrel export for all record-based helper functions. |
| ts/src/apps/quickbooks/helpers/record-based/constants.ts | Defines supported entities, capabilities, schemas, and helper utilities for record-based ops. |
| ts/src/apps/quickbooks/helpers/record-based/get-table-list.ts | Implements record-based table listing via supported entity names. |
| ts/src/apps/quickbooks/helpers/record-based/get-record-type.ts | Returns a static schema (record type) per QuickBooks entity. |
| ts/src/apps/quickbooks/helpers/record-based/get-expressions.ts | Defines supported WHERE/search expressions and maps them to app i18n. |
| ts/src/apps/quickbooks/helpers/record-based/get-search-options.ts | Defines record-based search options (orderBy). |
| ts/src/apps/quickbooks/helpers/record-based/apply-where-condition.ts | Converts WHERE trees into server-side criteria + client-side filtering fallback. |
| ts/src/apps/quickbooks/helpers/record-based/search-records.ts | Adds iterator-based record search with filtering/sorting and pagination. |
| ts/src/apps/quickbooks/helpers/record-based/create-records.ts | Implements batch create via QuickBooks batch API. |
| ts/src/apps/quickbooks/helpers/record-based/update-records.ts | Implements search-first + batch update with SyncToken handling. |
| ts/src/apps/quickbooks/helpers/record-based/delete-records.ts | Implements search-first + batch delete with SyncToken handling and safety checks. |
| ts/src/i18n/en/apps/Quickbooks/index.ts | Adds English i18n strings for the new expression operators. |
| ts/src/i18n/i18n-types.ts | Updates generated i18n type definitions to include expressions under QuickBooks. |
| ts/src/tests/quickbooks-record-based.test.ts | Adds unit tests for helpers and integration tests for CRUD/search against QuickBooks sandbox. |
| ts/src/global/helpers/index.ts | Minor typing adjustments impacting trigger mapping and option normalization. |
| ts/src/global/helpers/README_QORE_API_CLIENT.md | Removed documentation file (scope appears unrelated to QuickBooks record-based support). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… into feature/209-quickbooks-record-based
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.