Fix nullptr disconnect warning when destroying an OpenGL enabled chart#8
Closed
Fix nullptr disconnect warning when destroying an OpenGL enabled chart#8
Conversation
|
|
Author
|
I added a Minimal Reproducing Example here using PySide6. It's attached to this comment Starting the program will display an OpenGL enabled chart. Hitting the Delete key will destroy it. Before "Delete" : After "Delete" |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When destroying an OpenGL enabled chart, I encounter a reproducible warning :
qt.core.qobject.connect: QObject::disconnect: Unexpected nullptr parameterAfter review, I found that the
GLWidget::cleanup()can be called twice if the context is deleted before the GLWidget. The warning happens because the cleanup function is not idempotent and the second time tries to disconnect a nullptr.This PR aim to make the
cleanupfunction idempotent.The first call comes from the signal
QOpenGLContext::aboutToBeDestroyedand the second call comes from the GLWidget destructor.When using the public API of QtCharts in Python, I do not have control over the chart GLContext object lifecycle (as far as I know). I don't have a viable workaround other than fixing this root cause.