-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Implement live to live switch back #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement live to live switch back #139
Conversation
Summary of ChangesHello @sebastianpiq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant feature to improve the "live to live switch back" experience within the player. It introduces more robust seeking behavior for dynamic live streams by intelligently handling target seek times relative to the DVR window. Additionally, it provides new functionalities for managing the DVR window and includes general code cleanup and refactoring to enhance the player's stability and maintainability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements the switch back from a live alternative stream to the main live stream, ensuring seeks are handled correctly within the DVR window. The changes look good overall, but I've found a couple of minor issues: a typo in a variable name and a leftover debugging statement that should be removed.
|
|
||
| const type = streamController && streamController.hasVideoTrack() ? Constants.VIDEO : Constants.AUDIO; | ||
| const dvrInfo = dashMetrics.getCurrentDVRInfo(type); | ||
| console.log(dvrInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const erarlyToResolveEvent = _checkForEarliestResolutionTimeEvents(event); | ||
|
|
||
| if (!erarlyToResolveEvent || event.triggeredReadyToResolve) { | ||
| return false; | ||
| } | ||
|
|
||
| const resolutionTime = event.calculatedPresentationTime - event.alternativeMpd .earliestResolutionTimeOffset; | ||
| const resolutionTime = event.calculatedPresentationTime - erarlyToResolveEvent.earliestResolutionTimeOffset; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the variable name erarlyToResolveEvent. It should be earlyToResolveEvent for better readability and to avoid confusion. I've corrected it in the suggestion.
| const erarlyToResolveEvent = _checkForEarliestResolutionTimeEvents(event); | |
| if (!erarlyToResolveEvent || event.triggeredReadyToResolve) { | |
| return false; | |
| } | |
| const resolutionTime = event.calculatedPresentationTime - event.alternativeMpd .earliestResolutionTimeOffset; | |
| const resolutionTime = event.calculatedPresentationTime - erarlyToResolveEvent.earliestResolutionTimeOffset; | |
| const earlyToResolveEvent = _checkForEarliestResolutionTimeEvents(event); | |
| if (!earlyToResolveEvent || event.triggeredReadyToResolve) { | |
| return false; | |
| } | |
| const resolutionTime = event.calculatedPresentationTime - earlyToResolveEvent.earliestResolutionTimeOffset; |
… log in PlaybackController
c871f7f
into
feature/alternative-media-presentations
No description provided.