Skip to content

Alternative media presentations/playback ended #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 9, 2025
Merged

Alternative media presentations/playback ended #141

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8ae4399
WIP playback ended
cotid-qualabs Sep 26, 2025
ce43e1c
add dynamic to static listener
cotid-qualabs Sep 26, 2025
f0993c7
Merge branch 'feature/alternative-media-presentations' of github.com:…
cotid-qualabs Sep 26, 2025
25d1e8a
remove console log
cotid-qualabs Sep 26, 2025
6108c9f
even callback fix
cotid-qualabs Sep 26, 2025
9f6596f
fix event listeners
cotid-qualabs Sep 26, 2025
3ec54ac
rename listeners
cotid-qualabs Sep 26, 2025
88c1603
add missing condition on merge
cotid-qualabs Sep 26, 2025
e57ada0
fix from merge
cotid-qualabs Sep 26, 2025
9aa54bf
implement switchback for playback ended events
cotid-qualabs Sep 29, 2025
7f1070d
remove extra parentesis
cotid-qualabs Sep 29, 2025
6c86aa8
update comment
cotid-qualabs Sep 29, 2025
8c1d9ff
bugfix double switch back if vod
cotid-qualabs Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions src/streaming/controllers/AlternativeMediaController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@ function AlternativeMediaController() {
const altPlayer = mediaManager.getAlternativePlayer();
if (altPlayer) {
altPlayer.on(MediaPlayerEvents.PLAYBACK_TIME_UPDATED, _onAlternativePlaybackTimeUpdated, this);
altPlayer.on(MediaPlayerEvents.DYNAMIC_TO_STATIC, _onAlternativeDynamicToStatic, this)
altPlayer.on(MediaPlayerEvents.PLAYBACK_ENDED, _onAlternativePlaybackEnded, this)
}
} catch (err) {
logger.error('Error handling alternative event:', err);
Expand Down Expand Up @@ -282,21 +284,43 @@ function AlternativeMediaController() {
(calculatedMaxDuration && calculatedMaxDuration <= adjustedTime)
);
if (shouldSwitchBack) {
const seekTime = _calculateSeekTime(event, altPlayer);
mediaManager.switchBackToMainContent(seekTime);

// Trigger content end event
if (eventBus){
eventBus.trigger(Constants.ALTERNATIVE_MPD.CONTENT_END, { event });
}

_resetAlternativeSwitchStates();
_switchBackToMainContent(altPlayer, event);
}
} catch (err) {
logger.error(`Error at ${actualEventPresentationTime} in onAlternativePlaybackTimeUpdated:`, err);
}
}

function _onAlternativePlaybackEnded(e){
if (e.isLast){
const event = { ...currentEvent };
const altPlayer = mediaManager.getAlternativePlayer();
if (altPlayer.isDynamic()){
_switchBackToMainContent(altPlayer, event);
}
}
}

function _onAlternativeDynamicToStatic(){
const event = { ...currentEvent };
const altPlayer = mediaManager.getAlternativePlayer();
if (altPlayer.isDynamic()){
_switchBackToMainContent(altPlayer, event);
}
}

function _switchBackToMainContent(altPlayer, event) {
const seekTime = _calculateSeekTime(event, altPlayer);
mediaManager.switchBackToMainContent(seekTime);

// Trigger content end event
if (eventBus){
eventBus.trigger(Constants.ALTERNATIVE_MPD.CONTENT_END, { event });
}

_resetAlternativeSwitchStates();
}

function _calculateSeekTime(currentEvent, altPlayer) {
let seekTime;
if (currentEvent.mode === Constants.ALTERNATIVE_MPD.MODES.REPLACE) {
Expand Down