-
Notifications
You must be signed in to change notification settings - Fork 0
add returnOffset functional test #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add returnOffset functional test #142
Conversation
Summary of ChangesHello @cotid-qualabs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new functional test to ensure the correct behavior of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new functional test for the returnOffset feature in Alternative MPD scenarios, including test configuration and implementation. The new test is well-structured, but I have a few suggestions for improvement. There's a potential race condition in how playback time is checked after switching content, which could be fixed by sampling the time after a delay. Additionally, a small piece of logic for array initialization can be simplified for better readability. I also noticed a minor typo in the pull request title ('funcional' should be 'functional'). Overall, this is a valuable addition for test coverage.
test/functional/test/feature-support/alternative/alternative-mpd-returnOffset.js
Outdated
Show resolved
Hide resolved
test/functional/test/feature-support/alternative/alternative-mpd-returnOffset.js
Show resolved
Hide resolved
test/functional/test/feature-support/alternative/alternative-mpd-returnOffset.js
Outdated
Show resolved
Hide resolved
7095cc9
into
feature/alternative-media-presentations
No description provided.