chore: CMCDv2 migration to CMCD Reporter

[cotid-qualabs]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @cotid-qualabs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the CMCD implementation by adopting the CmcdReporter library. This strategic shift aims to reduce the complexity of CMCD data collection and transmission, centralizing reporting mechanisms and allowing the CmcdController and CmcdModel to focus on their core responsibilities of orchestrating and calculating data, respectively. The change enhances maintainability and aligns the project with external CMCD standards.

Highlights

• CMCD Reporter Integration: The core change involves migrating the CMCD (Common Media Client Data) implementation to utilize the CmcdReporter from the @svta/cml-cmcd library. This centralizes CMCD reporting logic and simplifies event handling.
• Refactored CMCD Controller: The CmcdController has been significantly refactored to instantiate and manage the CmcdReporter. This includes removing manual event mode handling, sequence number tracking, and custom HTTP request sending for CMCD reports, delegating these responsibilities to the new reporter.
• Streamlined CMCD Model: The CmcdModel has been simplified by removing internal state management for playback rate, manifest details, and error codes. Its primary role is now to calculate CMCD data for various request types, returning this data for the CmcdReporter to consume and transmit.
• Removed Redundant Code: Several functions related to manual CMCD data generation, request decoration, and event mode transmission (e.g., _sendCmcdDataReport, _updateRequestWithCmcd, getBodyParameters) have been removed from CmcdController as their functionality is now handled by the CmcdReporter.
• Updated Data Calculation Naming: Methods in CmcdModel responsible for calculating CMCD data have been renamed from getCmcdData to calculateCmcdDataForRequest and similar patterns for internal helper functions, improving clarity and consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a significant and well-executed refactoring to migrate the CMCD implementation to use the official @svta/cml-cmcd CmcdReporter. This is a great improvement as it replaces a large amount of custom logic with a specialized, standard library, which should improve maintainability and correctness. The changes in CmcdController.js and CmcdModel.js are extensive but logical. The CmcdModel has been simplified and made more stateless, which is a good design choice.

I've found one potential issue where constructing a URL object from a relative path could cause an error. I've included a suggestion to fix this. Overall, this is a solid contribution.

[gemini-code-assist]

new URL(request.url) will throw an error if request.url is a relative URL, which is often the case for media segment requests. This would cause the CMCD_DATA_GENERATED event to be missing the cmcdString. You should resolve the relative URL against a base URL, like the manifest URL, before parsing it.

                    const streamInfo = mediaPlayerModel.getStreamInfo();
                    const manifestUrl = streamInfo ? streamInfo.manifestInfo.url : null;
                    const fullUrl = new URL(request.url, manifestUrl);
                    eventData.cmcdString = fullUrl.searchParams.get(CMCD_PARAM) || '';