Skip to content

Enable SPEL powercap driver#1195

Merged
QuinAsura merged 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
dmantre:spel_powercap
May 20, 2026
Merged

Enable SPEL powercap driver#1195
QuinAsura merged 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
dmantre:spel_powercap

Conversation

@dmantre
Copy link
Copy Markdown

@dmantre dmantre commented May 20, 2026

The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware based power monitoring and limiting capabilities for various power domains including System, SoC, CPU clusters, GPU, and various other subsystems for glymur.

The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware
based power monitoring and limiting capabilities for various power
domains including System, SoC, CPU clusters, GPU, and various other
subsystems for glymur.

Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
Link: https://patch.msgid.link/20260519-qcom_spel_driver_upstream-v1-3-75356d1b7f94@oss.qualcomm.com
@qcomlnxci qcomlnxci requested review from a team, quic-tingweiz, sgaud-quic and yijiyang and removed request for a team May 20, 2026 07:07
@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1195

PR: #1195
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147126311

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during ci-merge integration arch/arm64/boot/dts/qcom/glymur.dtsi Yes PR adds a new power-controller@ef3b000 node to glymur.dtsi; the baseline (qcom-next) already has a conflicting change in the same region of that file
2 Merge conflict during ci-merge integration arch/arm64/boot/dts/qcom/glymur-crd.dtsi No Conflict is between the baseline (qcom-next) and another topic branch already in the integration tree; PR #1195 does not touch glymur-crd.dtsi
3 Merge conflict during ci-merge integration drivers/media/platform/qcom/iris/iris_hfi_queue.c No Conflict is between the baseline and another topic branch; PR #1195 does not touch this file
4 Merge conflict during ci-merge integration drivers/media/platform/qcom/iris/iris_vpu3x.c No Conflict is between the baseline and another topic branch; PR #1195 does not touch this file
5 Merge conflict during ci-merge integration drivers/media/platform/qcom/iris/iris_vpu_common.c No Conflict is between the baseline and another topic branch; PR #1195 does not touch this file

Verdict

1 of 5 merge conflicts is directly introduced by this PR (glymur.dtsi); the remaining 4 are pre-existing conflicts between the baseline (qcom-next) and other topic branches already in the integration tree, and would fail regardless of this PR.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1195

PR: #1195
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147126311

# Error File:Line PR-introduced? Root Cause
1 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur.dtsi Yes PR adds a new DT node near line 6028; qcom-next baseline has diverged in the same region, causing a content conflict during ci-merge auto-merge
2 Merge conflict (content) arch/arm64/boot/dts/qcom/glymur-crd.dtsi Yes (collateral) Companion file to glymur.dtsi; the PR's topic branch is behind qcom-next changes that also modify this file, surfacing a conflict
3 Merge conflict (content) drivers/media/platform/qcom/iris/iris_hfi_queue.c No Pre-existing conflict between other topic branches in the integration tree and qcom-next; not touched by this PR
4 Merge conflict (content) drivers/media/platform/qcom/iris/iris_vpu3x.c No Pre-existing conflict between other topic branches and qcom-next; not touched by this PR
5 Merge conflict (content) drivers/media/platform/qcom/iris/iris_vpu_common.c No Pre-existing conflict between other topic branches and qcom-next; not touched by this PR

Verdict

2 of 5 merge conflicts are introduced (or surfaced) by this PR; the remaining 3 are pre-existing conflicts in the integration tree unrelated to this PR's changes.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

PR #1195 — validate-patch

PR: #1195

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes — patch.msgid.link shortlink present, resolves to lore message-ID 20260519-qcom_spel_driver_upstream-v1-3-75356d1b7f94@oss.qualcomm.com; however the canonical https://lore.kernel.org/r/... form is preferred
  2. Lore link matches PR commits: Not verified — network access blocked; lore patch could not be fetched for diff comparison; no divergence detected from static analysis of the PR diff alone
  3. Upstream patch status: ⏳ Decision Pending — patch posted 2026-05-19 (same day as PR, v1); no merge or review signals observable without network access
  4. PR present in qcom-next: ⏭️ Skipped — local kernel mirror not available and network access blocked; verify manually with git log --grep="glymur: Enable SPEL powercap" on qcom-next
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: FROMLIST: arm64: dts: qcom: glymur: Enable SPEL powercap driver (#1195)
Upstream commit: https://patch.msgid.link/20260519-qcom_spel_driver_upstream-v1-3-75356d1b7f94@oss.qualcomm.com
Verdict: ⚠️ PARTIAL


Commit Message

Check Status Note
Subject matches upstream ⚠️ FROMLIST: prefix added — correct convention; subject body looks appropriate for a DTS enablement patch
Body preserves rationale Brief but adequate: describes SPEL hardware power monitoring/limiting for glymur
Fixes tag present/correct N/A Not a bugfix; no Fixes: tag expected
Authorship preserved FROMLIST: rule: submitter (Manaf Meethalavalappu Pallikunhi) is legitimately in From: and provides the sole Signed-off-by: — acceptable when submitter is also the lore patch author
Backport note (if applicable) N/A Not a backport
Co-developed-by misuse Not present; no misuse
Link tag format ⚠️ Uses patch.msgid.link shortlink, not the canonical https://lore.kernel.org/r/<msg-id> form required by tree conventions — should be updated

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi ⚠️ DTS node address mismatch: node is power-controller@ef3b000 but first reg entry is 0x0ef3e000 (0xef3e000); unit-address must match the first reg base address per DTS convention — should be power-controller@ef3e000

Note: Direct diff comparison against the lore patch could not be performed — network access is restricted in this environment and b4/curl to lore.kernel.org timed out. The diff content analysis above is based on inspection of the PR patch alone.


Issues

  1. Link tag not in canonical lore form — The Link: tag uses https://patch.msgid.link/20260519-qcom_spel_driver_upstream-v1-3-75356d1b7f94@oss.qualcomm.com (a redirect shortlink). Tree convention requires the canonical lore URL:

    Link: https://lore.kernel.org/r/20260519-qcom_spel_driver_upstream-v1-3-75356d1b7f94@oss.qualcomm.com
    
  2. DTS unit-address mismatch — The node name power-controller@ef3b000 does not match the first reg entry:

    +		power-controller@ef3b000 {          ← unit-address = 0xef3b000
    +			reg = <0x0 0x0ef3e000 0x0 0x1000>,  ← first reg base = 0xef3e000  ❌
    +			      <0x0 0x0ef3d000 0x0 0x1000>,
    +			      <0x0 0x0ef3b000 0x0 0x1000>;  ← "config" reg = 0xef3b000
    

    Per DTS convention (ePAPR §2.2.1), the unit-address must match the first address in the reg property. The node should be power-controller@ef3e000.

  3. Series dependency — The message-ID encodes this as patch 3 of a series (v1-3). Patches 1 and 2 (likely the SPEL driver and DT binding) must already be present in the target tree or included in accompanying PRs. This should be verified before merging.


Verdict

Request changes: fix the Link: tag to use the canonical lore.kernel.org URL, correct the DTS node unit-address from @ef3b000 to @ef3e000 (to match the first reg base address 0x0ef3e000), and confirm that the prerequisite patches 1 and 2 of the series are already in the target branch.


Final Summary

  1. Lore link present: Yes — patch.msgid.link shortlink present, resolves to lore message-ID 20260519-qcom_spel_driver_upstream-v1-3-75356d1b7f94@oss.qualcomm.com; however the canonical https://lore.kernel.org/r/... form is preferred
  2. Lore link matches PR commits: Not verified — network access blocked; lore patch could not be fetched for diff comparison; no divergence detected from static analysis of the PR diff alone
  3. Upstream patch status: ⏳ Decision Pending — patch posted 2026-05-19 (same day as PR, v1); no merge or review signals observable without network access
  4. PR present in qcom-next: ⏭️ Skipped — local kernel mirror not available and network access blocked; verify manually with git log --grep="glymur: Enable SPEL powercap" on qcom-next

@qlijarvis
Copy link
Copy Markdown

PR #1195 — checker-log-analyzer

PR: #1195
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147126395

Checker Result Summary
Checker Result Summary
checkpatch Merge conflict in integration step — checker logic never ran
dt-binding-check Merge conflict in integration step — checker logic never ran
dtb-check Merge conflict in integration step — checker logic never ran
sparse-check Merge conflict in integration step — checker logic never ran
check-uapi-headers Merge conflict in integration step — checker logic never ran
check-patch-compliance Merge conflict in integration step — checker logic never ran
tag-check FROMLIST: prefix present on the single commit
qcom-next-check FROMLIST: prefix is valid for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST: arm64: dts: qcom: glymur: Enable SPEL powercap driver (#1195)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147126395

Checker Result Summary
checkpatch Merge conflict in integration step — checker logic never ran
dt-binding-check Merge conflict in integration step — checker logic never ran
dtb-check Merge conflict in integration step — checker logic never ran
sparse-check Merge conflict in integration step — checker logic never ran
check-uapi-headers Merge conflict in integration step — checker logic never ran
check-patch-compliance Merge conflict in integration step — checker logic never ran
tag-check FROMLIST: prefix present on the single commit
qcom-next-check FROMLIST: prefix is valid for this branch

❌ All Checkers — Integration Merge Failure (Not a Patch Defect)

Root cause: The CI automerge step failed to merge topic branch topic/tech/all/dt/glymur into the integration branch due to 20 unresolved merge conflicts with other topic branches; no checker ran its actual analysis logic.

Failure details:

Running automerge...
CONFLICT (content): Merge conflict in Makefile
CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/glymur-crd.dtsi
CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/glymur.dtsi
CONFLICT (content): Merge conflict in drivers/acpi/acpi_tad.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/xe/xe_dma_buf.c
CONFLICT (content): Merge conflict in drivers/media/platform/qcom/iris/iris_hfi_queue.c
CONFLICT (content): Merge conflict in drivers/media/platform/qcom/iris/iris_vpu3x.c
CONFLICT (content): Merge conflict in drivers/media/platform/qcom/iris/iris_vpu_common.c
CONFLICT (content): Merge conflict in drivers/nvme/host/pci.c
CONFLICT (content): Merge conflict in drivers/nvme/target/tcp.c
CONFLICT (content): Merge conflict in io_uring/napi.c
CONFLICT (content): Merge conflict in kernel/cgroup/cgroup.c
CONFLICT (content): Merge conflict in kernel/cgroup/cpuset.c
CONFLICT (content): Merge conflict in kernel/sched/ext.c
CONFLICT (content): Merge conflict in net/netfilter/nf_tables_api.c
CONFLICT (content): Merge conflict in net/sched/sch_cake.c
CONFLICT (content): Merge conflict in sound/soc/codecs/ab8500-codec.c
CONFLICT (content): Merge conflict in sound/soc/codecs/tas2770.c
Merge failed, manual merge
automerge returned non-zero; check logs for conflicts
##[error]Process completed with exit code 1.

Important: None of these conflicting files are touched by this PR. The PR only modifies arch/arm64/boot/dts/qcom/glymur.dtsi. The conflicts are between other topic branches being merged into the same integration branch. This is a tree-wide integration conflict, not a defect in this PR's patch.

Fix: No patch change needed. The conflicts must be resolved at the integration/automerge level by the tree maintainer. Options:

  1. Re-trigger CI after the conflicting topic branches have been rebased or the automerge configuration is updated to resolve the conflicts.
  2. Notify the tree maintainer that topic/tech/all/dt/glymur has integration conflicts with other active topic branches (listed above) that need resolution in the merge configuration.

Reproduce locally:

# Not applicable — this is a CI integration infrastructure issue, not a patch defect.
# The PR patch itself is clean and applies without conflict to its base branch.

✅ Patch Quality Assessment (from pr.patch)

The single commit in this PR is well-formed:

  • Subject prefix: FROMLIST:
  • Signed-off-by: Present (Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>) ✅
  • Link: Present (https://patch.msgid.link/20260519-qcom_spel_driver_upstream-v1-3-75356d1b7f94@oss.qualcomm.com) ✅
  • Change: Adds power-controller@ef3b000 DTS node with compatible = "qcom,spel" to glymur.dtsi — a single-file, DTS-only change ✅

Verdict

0 patch defects. All 6 checker failures are caused by a tree-wide integration merge conflict in the CI automerge step — none of the 20 conflicting files are part of this PR. Re-trigger CI after the integration conflicts are resolved by the tree maintainer.

@QuinAsura QuinAsura merged commit 1784993 into qualcomm-linux:tech/all/dt/glymur May 20, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants