Skip to content

add IMEM and PIL regions#1311

Open
pradyot7 wants to merge 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
pradyot7:glymur-IMEM
Open

add IMEM and PIL regions#1311
pradyot7 wants to merge 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
pradyot7:glymur-IMEM

Conversation

@pradyot7
Copy link
Copy Markdown

@pradyot7 pradyot7 commented Jun 4, 2026

…glymur

Add an IMEM on glymur which falls back to mmio-sram and define the PIL relocation info region as its child, for post mortem tools to locate the loaded remoteprocs.

Link: https://lore.kernel.org/lkml/20260424-glymur-imem-v5-2-18ede63cf063@oss.qualcomm.com/#r

…glymur

Add an IMEM on glymur which falls back to mmio-sram and define the
PIL relocation info region as its child, for post mortem tools to
locate the loaded remoteprocs.

Link: https://lore.kernel.org/lkml/20260424-glymur-imem-v5-2-18ede63cf063@oss.qualcomm.com/#r
Signed-off-by: Ananthu C V <ananthu.cv@oss.qualcomm.com>
Signed-off-by: Pradyot Kumar Nayak <pradyot.nayak@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, sgaud-quic, shashim-quic and yijiyang and removed request for a team June 4, 2026 18:48
@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1311

PR: #1311
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26972489715

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during integration arch/arm64/configs/defconfig No Pre-existing conflict between baseline and topic branch unrelated to PR changes

Verdict

This is not a compilation failure. The build failed during the integration/merge phase before compilation began. The merge conflict in arch/arm64/configs/defconfig is pre-existing and not introduced by this PR, which only modifies arch/arm64/boot/dts/qcom/glymur.dtsi.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1311

PR: #1311
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26972489715

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge arch/arm64/configs/defconfig No Pre-existing conflict between baseline (8b79525f) and topic branch (topic/tech/all/dt/glymur). The PR only modifies glymur.dtsi, not defconfig.

Verdict

This is not a compilation error. The build failed during the automerge phase due to a merge conflict in arch/arm64/configs/defconfig. The PR itself does not introduce any compilation errors—it only adds device tree nodes to glymur.dtsi.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

PR #1311 — validate-patch

PR: #1311

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes — Link tag points to v5 patch series on lore.kernel.org from 2026-04-24
  2. Lore link matches PR commits: Cannot verify — network access restricted; unable to fetch upstream patch for byte-level comparison
  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged into mainline
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1311 - FROMLIST: arch: arm64: boot: dts: qcom: add IMEM and PIL regions for glymur
Upstream commit: https://lore.kernel.org/lkml/20260424-glymur-imem-v5-2-18ede63cf063@oss.qualcomm.com/#r
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Subject format non-standard: "arch: arm64: boot: dts: qcom:" should be "arm64: dts: qcom:" per kernel convention
Body preserves rationale Clear explanation of IMEM and PIL relocation region purpose
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Original author Ananthu C V preserved
Backport note (if applicable) N/A FROMLIST prefix indicates patch under review, not yet merged

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur.dtsi Clean addition of IMEM sram@14680000 node with PIL child node

Issues

  • Subject prefix non-standard: The subject uses "arch: arm64: boot: dts: qcom:" but kernel DTS patches typically use "arm64: dts: qcom:" format. The extra "arch:" and "boot:" prefixes are redundant.
  • Lore link has fragment: The Link tag includes "#r" fragment which is unusual; typically lore links point to the raw message without fragments.

Verdict

Patch is functionally correct with proper authorship and clear rationale, but subject line deviates from standard kernel DTS naming convention. Consider updating subject to "arm64: dts: qcom: glymur: add IMEM and PIL regions" to match subsystem style.

Final Summary

  1. Lore link present: Yes — Link tag points to v5 patch series on lore.kernel.org from 2026-04-24
  2. Lore link matches PR commits: Cannot verify — network access restricted; unable to fetch upstream patch for byte-level comparison
  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged into mainline
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

@qlijarvis
Copy link
Copy Markdown

PR #1311 — checker-log-analyzer

PR: #1311
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26972490476

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Skipped - automerge conflict blocked execution
dt-binding-check ⏭️ Skipped - automerge conflict blocked execution
dtb-check ⏭️ Skipped - automerge conflict blocked execution
sparse-check ⏭️ Skipped - automerge conflict blocked execution
check-uapi-headers ⏭️ Skipped - automerge conflict blocked execution
check-patch-compliance ⏭️ Skipped - automerge conflict blocked execution
tag-check Subject prefix FROMLIST: is correct
qcom-next-check FROMLIST commit with valid lore link

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1311 - FROMLIST: arch: arm64: boot: dts: qcom: add IMEM and PIL regions for glymur
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26972490476

Checker Result Summary
checkpatch ⏭️ Skipped - automerge conflict blocked execution
dt-binding-check ⏭️ Skipped - automerge conflict blocked execution
dtb-check ⏭️ Skipped - automerge conflict blocked execution
sparse-check ⏭️ Skipped - automerge conflict blocked execution
check-uapi-headers ⏭️ Skipped - automerge conflict blocked execution
check-patch-compliance ⏭️ Skipped - automerge conflict blocked execution
tag-check Subject prefix FROMLIST: is correct
qcom-next-check FROMLIST commit with valid lore link

❌ Automerge Conflict (Infrastructure Issue)

Root cause: All checker jobs failed during the automerge phase when attempting to merge the base branch tech/all/dt/glymur with the integration baseline, encountering a merge conflict in arch/arm64/configs/defconfig.

Failure details:

2026-06-04T19:06:03.7206589Z CONFLICT (content): Merge conflict in arch/arm64/configs/defconfig
2026-06-04T19:06:03.7853678Z Automatic merge failed; fix conflicts and then commit the result.
2026-06-04T19:06:03.7981334Z Merge failed, manual merge
2026-06-04T19:06:03.9649138Z ##[error]Process completed with exit code 1.

This same conflict pattern appears in all six checker logs:

  • checker__checkpatch____checker.txt (line 2026-06-04T19:06:03)
  • checker__dt-binding-check____checker.txt (line 2026-06-04T19:05:09)
  • checker__dtb-check____checker.txt (line 2026-06-04T19:04:59)
  • checker__sparse-check____checker.txt (line 2026-06-04T19:04:46)
  • checker__check-uapi-headers____checker.txt (line 2026-06-04T19:04:10)
  • checker__check-patch-compliance____checker.txt (line 2026-06-04T19:05:24)

Analysis:

This is not a problem with the PR patch itself. The patch only modifies arch/arm64/boot/dts/qcom/glymur.dtsi (adding IMEM and PIL SRAM nodes), which is a clean devicetree change. The conflict occurs in arch/arm64/configs/defconfig, which is not touched by this PR.

The conflict is in the base branch (tech/all/dt/glymur) when the CI attempts to merge it with the integration baseline (tag 8b79525f5fd0f6893b67ea128db176132eafbabc). This indicates that the base branch has diverged from the integration baseline and contains conflicting changes to the defconfig.

Fix:

This requires action on the base branch, not the PR:

  1. Option A (Recommended): Rebase the base branch tech/all/dt/glymur onto the latest integration baseline to resolve the defconfig conflict:

    git checkout tech/all/dt/glymur
    git fetch origin
    git rebase 8b79525f5fd0f6893b67ea128db176132eafbabc
    # Resolve conflicts in arch/arm64/configs/defconfig
    git rebase --continue
    git push --force-with-lease
  2. Option B: Merge the integration baseline into the base branch:

    git checkout tech/all/dt/glymur
    git merge 8b79525f5fd0f6893b67ea128db176132eafbabc
    # Resolve conflicts in arch/arm64/configs/defconfig
    git commit
    git push
  3. Option C: If the defconfig changes in the base branch are not needed, reset the base branch to exclude those changes.

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout tech/all/dt/glymur
git merge 8b79525f5fd0f6893b67ea128db176132eafbabc
# Conflict will appear in arch/arm64/configs/defconfig

✅ Patch Content Analysis

The PR patch itself is clean:

  • Subject: Properly prefixed with FROMLIST: indicating upstream submission
  • Link: Valid lore.kernel.org reference to v5 of the patch series
  • Content: Adds IMEM SRAM node and PIL relocation info child node to glymur.dtsi
  • Style: Follows devicetree conventions (node naming, property ordering, indentation)
  • Scope: Single file change, focused and minimal

No checkpatch, dt-binding, dtb, sparse, or UAPI issues are expected from this patch content.

Verdict

Infrastructure blocker: The base branch tech/all/dt/glymur has a merge conflict with the integration baseline in arch/arm64/configs/defconfig. This must be resolved in the base branch before checkers can run. The PR patch itself appears clean and should pass all checkers once the base branch conflict is resolved.

Action required: Maintainer must resolve the defconfig conflict in the base branch tech/all/dt/glymur, then re-trigger the checker workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants