arm64: dts: qcom: qcs6490-rb3gen2: fix root node overlay for phy-supply#454
Merged
sgaud-quic merged 1 commit intoqualcomm-linux:qcom-6.18.yfrom Apr 13, 2026
Merged
Conversation
… phy-vreg
The staging overlay used a bare "/ {" root node block to define the
qep_vreg and aqr_vreg fixed regulators. In a DT overlay, a bare "/ {"
creates a new root fragment that is not merged into the base tree's
root node; as a result the regulator nodes are never instantiated and
the tc956x driver cannot resolve the phy-supply phandle, leading to a
failed MDIO probe:
tc956x_pci-eth 0001:05:00.1: No PHY found
Replace "/ {" with the overlay-correct "&{/} {" syntax so that the
fragment is properly applied as an amendment to the base device-tree
root node. This ensures the regulator nodes are present at boot and
the PHY powers up correctly.
Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
d319936 to
59451a9
Compare
shashim-quic
approved these changes
Apr 13, 2026
Test Matrix
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The staging overlay used a bare "/ {" root node block to define the qep_vreg and aqr_vreg fixed regulators. In a DT overlay, a bare "/ {" creates a new root fragment that is not merged into the base tree's root node; as a result the regulator nodes are never instantiated and the tc956x driver cannot resolve the phy-supply phandle, leading to a failed MDIO probe:
tc956x_pci-eth 0001:05:00.1: No PHY found
Replace "/ {" with the overlay-correct "&{/} {" syntax so that the fragment is properly applied as an amendment to the base device-tree root node. This ensures the regulator nodes are present at boot and the PHY powers up correctly.
Mainline PR: qualcomm-linux/kernel-topics#933
CRs-Fixed: 4499524