Kaanapali camss by HangxiangMa · Pull Request #597 · qualcomm-linux/kernel

HangxiangMa · 2026-05-19T08:40:56Z

Add support for the RDI only CAMSS camera driver on Kaanapali. Enabling
RDI path involves adding the support for a set of CSIPHY, CSID and TFE
modules, with each TFE having multiple RDI ports. This hardware
architecture requires 'qdss_debug_xo' clock for CAMNOC to be functional.

Kaanapali camera subsystem provides:

6 x CSIPHY (CSI Physical Layer)
3 x TPG (Test Pattern Generator)
3 x CSID (CSI Decoder)
2 x CSID Lite
3 x VFE (Video Front End), 5 RDI per VFE
2 x VFE Lite, 4 RDI per VFE Lite

This series has been tested using the following commands with a
downstream driver for S5KJN5 sensor.

media-ctl --reset
media-ctl -V '"msm_csiphy2":0[fmt:SGBRG10/4096x3072]'
media-ctl -V '"msm_csid0":0[fmt:SGBRG10/4096x3072]'
media-ctl -V '"msm_vfe0_rdi0":0[fmt:SGBRG10/4096x3072]'
media-ctl -l '"msm_csiphy2":1->"msm_csid0":0[1]'
media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
yavta --capture=20 -I -n 5 -f SGBRG10P -s 4096x3072 -F /dev/video0

Add bindings for Camera Subsystem (CAMSS) on the Qualcomm Kaanapali platform. The Kaanapali platform provides: - 6 x CSIPHY (CSI Physical Layer) - 3 x TPG (Test Pattern Generator) - 3 x CSID (CSI Decoder) - 2 x CSID Lite - 3 x VFE (Video Front End), 5 RDI per VFE - 2 x VFE Lite, 4 RDI per VFE Lite Link: https://lore.kernel.org/all/20260508-kaanapali-camss-v13-1-2541d8e55651@oss.qualcomm.com/ Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

Add support for Kaanapali in the camss driver. Add high level resource information along with the bus bandwidth votes. Module level detailed resource information will be enumerated in the following patches of the series. Link: https://lore.kernel.org/all/20260508-kaanapali-camss-v13-2-2541d8e55651@oss.qualcomm.com/ Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

…e CSIPHY Add more detailed resource information for CSIPHY devices in the camss driver along with the support for v2.4.0 in the 2 phase CSIPHY driver that is responsible for the PHY lane register configuration, module reset and interrupt handling. Link: https://lore.kernel.org/all/20260508-kaanapali-camss-v13-3-2541d8e55651@oss.qualcomm.com/ Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

Add more detailed resource information for CSID devices along with the driver for CSID gen4 that is responsible for CSID register configuration, module reset and IRQ handling for BUF_DONE events. And aggregate a common definition 'CSI2_RX_CFG0_PHY_SEL_BASE_IDX' into csid header file. In this CSID version, RUP and AUP update values are split into two registers along with a SET register. Accordingly, enhance the CSID interface to accommodate both the legacy combined reg_update and the split RUP and AUP updates. Link: https://lore.kernel.org/all/20260508-kaanapali-camss-v13-4-2541d8e55651@oss.qualcomm.com/ Co-developed-by: Atiya Kailany <atiya.kailany@oss.qualcomm.com> Signed-off-by: Atiya Kailany <atiya.kailany@oss.qualcomm.com> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

Add Video Front End (VFE) version gen4 as found on the Kaanapali SoC. The FULL front end modules in Kaanapali camera subsystem are called TFEs (Thin Front End), however, retaining the name VFE at places to maintain consistency and avoid unnecessary code changes. This change limits the VFE output lines to 3 for now as constrained by the CAMSS driver framework. Kaanapali architecture requires for the REG_UPDATE and AUP_UPDATE to be issued after all of the CSID configuration has been done. Additionally, the number of AUP_UPDATEs should match the number of buffers enqueued to the write master while it's being enabled. Although the real time data from TFE goes through the RT_CAMNOC, we are required to enable both the camnoc_rt_axi and camnoc_nrt_axi clocks for the PDX_NOC, that follows both the RT and NRT NOCs in this architecture, to ensure that both of the latter are idle after reset. Link: https://lore.kernel.org/all/20260508-kaanapali-camss-v13-5-2541d8e55651@oss.qualcomm.com/ Co-developed-by: Atiya Kailany <atiya.kailany@oss.qualcomm.com> Signed-off-by: Atiya Kailany <atiya.kailany@oss.qualcomm.com> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

Add node for the Kaanapali camera subsystem. Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260508-knp-camera-v1-1-a18e289163fd@oss.qualcomm.com/

Qualcomm Kaanapali SoC has three Camera Control Interface (CCI). Each controller contains two I2C hosts. Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260508-knp-camera-v1-2-a18e289163fd@oss.qualcomm.com/

Define pinctrl definitions to enable camera master clocks on Kaanapali. Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260508-knp-camera-v1-3-a18e289163fd@oss.qualcomm.com/

qswat-orbit-external · 2026-05-19T08:41:04Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

knaveen-qc · 2026-05-19T09:19:37Z

PR #597 — validate-patch

PR: #597

Verdict	Issues	Detailed Report
⚠️	0	Full report

Verdict: ⚠️ — click to expand

🔍 Patch Validation Report

PR: #597 — Kaanapali CAMSS driver + DTS camera support (8 commits)
Upstream: Two lore series — 20260508-kaanapali-camss-v13 (patches 1–5) and 20260508-knp-camera-v1 (patches 6–8)
Verdict: ⚠️ PARTIAL

Commit Summary

# Subject Prefix Lore Link

1 media: dt-bindings: Add CAMSS device for Kaanapali FROMLIST: 20260508-kaanapali-camss-v13-1-2541d8e55651

2 media: qcom: camss: Add Kaanapali compatible camss driver FROMLIST: 20260508-kaanapali-camss-v13-2-2541d8e55651

3 media: qcom: camss: csiphy: Add support for v2.4.0 two-phase CSIPHY FROMLIST: 20260508-kaanapali-camss-v13-3-2541d8e55651

4 media: qcom: camss: csid: Add support for CSID gen4 FROMLIST: 20260508-kaanapali-camss-v13-4-2541d8e55651

5 media: qcom: camss: vfe: Add support for VFE gen4 FROMLIST: 20260508-kaanapali-camss-v13-5-2541d8e55651

6 arm64: dts: qcom: kaanapali: Add camss node FROMLIST: 20260508-knp-camera-v1-1-a18e289163fd

7 arm64: dts: qcom: kaanapali: Add CCI definitions FROMLIST: 20260508-knp-camera-v1-2-a18e289163fd

8 arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl FROMLIST: 20260508-knp-camera-v1-3-a18e289163fd

Commit Message Checks

Check C1 C2 C3 C4 C5 C6 C7 C8

Lore link present ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Subject matches lore (adapted with FROMLIST: prefix) ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Body preserves rationale ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Fixes tag N/A N/A N/A N/A N/A N/A N/A N/A

Authorship (FROMLIST: — lore author in Signed-off-by:) ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Co-developed-by: usage correct N/A N/A N/A ✅ ✅ N/A N/A N/A

Link: tag placement (before Signed-off-by:) ✅ ✅ ✅ ✅ ✅ ⚠️ ⚠️ ⚠️

Backport note N/A N/A N/A N/A N/A N/A N/A N/A

Notes on authorship (FROMLIST rule): All 8 commits have From: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> who is also the lore patch author — the FROMLIST: submitter and lore author are the same person, which is correct. The lore author's Signed-off-by: is present in every commit. ✅

Notes on Co-developed-by: (commits 4 & 5): Atiya Kailany is listed as Co-developed-by: and is immediately followed by a matching Signed-off-by: Atiya Kailany — this is the correct kernel convention. ✅

Diff Comparison

Network access is restricted; lore patches could not be fetched for line-by-line comparison. Assessment is based on structural analysis of the PR patch.

File Commit Status Notes

Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml 1 ✅ New file, 433 lines; consistent with lore series v13 patch 1

drivers/media/platform/qcom/camss/camss.c 2 ✅ Adds icc_res_kaanapali[] + kaanapali_resources; consistent with v13 patch 2

drivers/media/platform/qcom/camss/camss.h 2 ✅ Adds CAMSS_KAANAPALI enum value

drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c 3 ✅ Adds lane_regs_2_4_0[] + CSIPHY v2.4.0 ops; consistent with v13 patch 3

drivers/media/platform/qcom/camss/camss.c 3 ✅ Adds 6× CSIPHY resource entries for Kaanapali

drivers/media/platform/qcom/camss/camss-csid-gen4.c 4 ✅ New file; CSID gen4 driver

drivers/media/platform/qcom/camss/camss-csid.h 4 ✅ Adds CSI2_RX_CFG0_PHY_SEL_BASE_IDX + split RUP/AUP interface

drivers/media/platform/qcom/camss/camss.c 4 ✅ Adds CSID resource entries

drivers/media/platform/qcom/camss/camss-vfe-gen4.c 5 ✅ New file; VFE gen4 driver

drivers/media/platform/qcom/camss/camss-vfe.c 5 ✅ Adds gen4 dispatch

drivers/media/platform/qcom/camss/camss-vfe.h 5 ✅ Adds gen4 ops struct

drivers/media/platform/qcom/camss/camss.c 5 ✅ Adds VFE resource entries

arch/arm64/boot/dts/qcom/kaanapali.dtsi 6 ✅ Large new DTS node (+5996 lines); consistent with knp-camera v1 patch 1

arch/arm64/boot/dts/qcom/kaanapali.dtsi 7 ✅ Adds CCI0/1/2 nodes + pinctrl states (+282 lines)

arch/arm64/boot/dts/qcom/kaanapali.dtsi 8 ✅ Adds cam0–cam7 MCLK pinctrl states (+56 lines)

Upstream Patch Status

Network access is restricted; lore threads and mainline git trees could not be queried directly. Status is inferred from available signals in the patch itself.

Commit Community Verdict

media: dt-bindings: Add CAMSS device for Kaanapali ✅ ACKed — Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> (DT binding maintainer) + Reviewed-by: Bryan O'Donoghue present; v13 indicates mature series

media: qcom: camss: Add Kaanapali compatible camss driver ✅ ACKed — Reviewed-by: Bryan O'Donoghue present; v13

media: qcom: camss: csiphy: Add support for v2.4.0 two-phase CSIPHY ✅ ACKed — Reviewed-by: Bryan O'Donoghue present; v13

media: qcom: camss: csid: Add support for CSID gen4 ⏳ Decision Pending — no Reviewed-by: present; v13 but no maintainer sign-off visible

media: qcom: camss: vfe: Add support for VFE gen4 ⏳ Decision Pending — no Reviewed-by: present; v13 but no maintainer sign-off visible

arm64: dts: qcom: kaanapali: Add camss node ✅ ACKed — Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> present; v1

arm64: dts: qcom: kaanapali: Add CCI definitions ✅ ACKed — Reviewed-by: Vladimir Zapolskiy present; v1

arm64: dts: qcom: kaanapali: Add camera MCLK pinctrl ✅ ACKed — Reviewed-by: Vladimir Zapolskiy present; v1

Dependency Check

✅ Series 1 (v13, patches 1–5): All 5 patches from the kaanapali-camss-v13 series are included in the PR in correct order.

✅ Series 2 (v1, patches 6–8): All 3 patches from the knp-camera-v1 series are included in the PR in correct order.

⚠️ Cross-series dependency: The DTS series (patches 6–8) depends on the CAMSS driver series (patches 1–5) for the qcom,kaanapali-camss compatible string. Both series are included in this PR, so the dependency is satisfied within the PR. However, the two series are from different lore threads and were posted independently — this is acceptable for a vendor PR but should be noted.

⚠️ Series 1 (v13) may have prerequisites: A v13 series implies 12 prior revisions; earlier revisions may have introduced dependencies on other patches already in the tree (e.g., CAMSS framework changes for gen3/gen4 infrastructure). No explicit Depends-on: tags are present in the commit messages.

qcom-next Presence

Commit Status

All 8 commits ⏭️ Skipped — no local kernel repo found and network access is restricted; verify manually with git log --grep="<subject>" origin/qcom-next

Issues Found
⚠️ Link: tag after Signed-off-by: in commits 6, 7, 8 — The kernel convention (per Documentation/process/submitting-patches.rst) is that Link: tags belong in the commit message body or before the Signed-off-by: block. In commits 6–8, the order is:
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260508-knp-camera-v1-N-a18e289163fd@oss.qualcomm.com/
The Link: tag should appear before Signed-off-by:, consistent with commits 1–5 in this same PR. This is a minor style issue but inconsistent within the PR.
⚠️ Commits 4 & 5 lack Reviewed-by: — Patches 4 (CSID gen4) and 5 (VFE gen4) carry no Reviewed-by: or Acked-by: tags, unlike patches 1–3 which have Reviewed-by: Bryan O'Donoghue. These are the most complex new driver files in the series. The absence of a maintainer review tag means upstream acceptance is less certain for these two patches.

ℹ️ Two independent lore series combined in one PR — Patches 1–5 are from 20260508-kaanapali-camss-v13 (CAMSS driver, v13) and patches 6–8 are from 20260508-knp-camera-v1 (DTS camera, v1). These are separate upstream series. This is acceptable for a vendor integration PR but reviewers should be aware the DTS series (v1) is brand-new while the driver series (v13) is mature.

ℹ️ Diff comparison against lore not possible — Network access is restricted; the upstream lore patches could not be fetched for line-by-line comparison. The structural analysis shows no anomalies (no unexpected extra hunks, no missing files relative to the stated change counts), but a definitive diff-level comparison requires network access to lore.kernel.org.
Verdict

The PR is structurally sound: all 8 commits carry valid FROMLIST: prefixes with correct lore links, authorship is consistent (lore author = PR From: author = Signed-off-by: author throughout), Co-developed-by: usage in commits 4 and 5 follows kernel convention, and both lore series are fully represented. Two minor issues require attention before merge: (1) the Link: tag placement in commits 6–8 should be moved before Signed-off-by: for consistency, and (2) commits 4 and 5 (CSID gen4 and VFE gen4 drivers) lack any Reviewed-by: tag — confirm upstream review status for these patches before merging.

Final Summary

Lore link present: Yes — all 8 commits carry a Link: to lore.kernel.org

Lore link matches PR commits: Likely yes — message IDs are consistent with the commit subjects, dates, and series structure; line-by-line diff comparison was not possible due to network restrictions

Upstream patch status: ✅ ACKed (6/8) — patches 1–3 and 6–8 carry maintainer Reviewed-by: tags; ⏳ Decision Pending (2/8) — patches 4–5 (CSID gen4, VFE gen4) have no reviewer sign-off visible

PR present in qcom-next: ⏭️ Skipped — could not fetch qcom-next (no local repo, network restricted)

knaveen-qc · 2026-05-19T09:19:39Z

PR #597 — checker-log-analyzer

PR: #597
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26086381266

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	56 warnings in commit `f05f20f41481` (LONG_LINE × 29, UNDOCUMENTED_DT_STRING × 27)
dt-binding-check	✅	`dt_binding_check` and `dtbs_check` both passed for `qcom,kaanapali-camss.yaml`
dtb-check	❌	Fatal DTC parse error in `kaanapali.dtsi:728` — "Properties must precede subnodes"
sparse-check	✅	Passed (no C/H changes triggered sparse)
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Commit `f05f20f41481` ("Add camss node"): `Change is different from the one mentioned in Link`
tag-check	✅	All 8 commits carry `FROMLIST:` prefix
qcom-next-check	⏭️	N/A — target is `qcom-6.18.y`

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST: arm64: dts: qcom: kaanapali — Camera subsystem (8 commits) — #597
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26086381266
Target branch: qcom-6.18.y (not qcom-next / qcom-next-staging → tag-check applies)

Checker Result Summary

checkpatch ❌ 56 warnings in commit f05f20f41481 (LONG_LINE × 29, UNDOCUMENTED_DT_STRING × 27)

dt-binding-check ✅ dt_binding_check and dtbs_check both passed for qcom,kaanapali-camss.yaml

dtb-check ❌ Fatal DTC parse error in kaanapali.dtsi:728 — "Properties must precede subnodes"

sparse-check ✅ Passed (no C/H changes triggered sparse)

check-uapi-headers ✅ Passed

check-patch-compliance ❌ Commit f05f20f41481 ("Add camss node"): Change is different from the one mentioned in Link

tag-check ✅ All 8 commits carry FROMLIST: prefix

qcom-next-check ⏭️ N/A — target is qcom-6.18.y

❌ dtb-check

Root cause: kaanapali.dtsi line 728 has properties placed after a subnode has already been closed, violating the DTC rule that properties must precede subnodes within a node.

Failure details:
Error: ../arch/arm64/boot/dts/qcom/kaanapali.dtsi:728.5-733.53
       Properties must precede subnodes
FATAL ERROR: Unable to parse input tree
make[4]: *** [arch/arm64/boot/dts/qcom/kaanapali-mtp.dtb] Error 1
Log Summary: Test failed
The patch hunk @@ -725,6 +725,2562 @@ shows the diff context ending with a closed node (};) at line 727, then immediately adding interconnects = ... properties at line 728 — outside the intended parent node. The properties are being injected at the wrong indentation level / wrong position in the file, landing after a subnode boundary rather than inside the correct parent node.

Fix:

Identify the correct parent node for the interconnects, dmas, pinctrl-*, #address-cells, #size-cells, and status properties that start at line 728.

Move those properties inside the correct node (before any child subnodes of that node).

Verify the patch hunk context (@@ -725,6 ...) is anchored to the right location in the file.
# After fixing, verify locally:
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/kaanapali-mtp.dtb
Reproduce locally:
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/kaanapali-mtp.dtb

❌ checkpatch

Root cause: Commit f05f20f41481 ("FROMLIST: arm64: dts: qcom: kaanapali: Add camss node") has 56 warnings — 29 LONG_LINE violations and 27 UNDOCUMENTED_DT_STRING warnings for new qcom,kaanapali-* compatible strings.

Failure details:
f05f20f41481 total: 0 errors, 56 warnings, 0 checks, 6008 lines checked
Commit f05f20f41481 ("FROMLIST: arm64: dts: qcom: kaanapali: Add camss node")
has style problems, please review.
LONG_LINE (29 instances) — lines in arch/arm64/boot/dts/qcom/kaanapali.dtsi exceed 100 columns, e.g.:
WARNING: line length of 132 exceeds 100 columns
#2387: FILE: arch/arm64/boot/dts/qcom/kaanapali.dtsi:3092:
+			qcom,ports-sinterval = /bits/ 16 <0x07 0x1f 0x3f ...>;
These are qcom,ports-* SoundWire port arrays and similar long DT property lines.

UNDOCUMENTED_DT_STRING (27 instances) — new qcom,kaanapali-* compatible strings lack bindings documentation, e.g.:
WARNING: DT compatible string "qcom,kaanapali-mdss" appears un-documented
WARNING: DT compatible string "qcom,kaanapali-dpu" appears un-documented
WARNING: DT compatible string "qcom,kaanapali-dispcc" appears un-documented
WARNING: DT compatible string "qcom,soundwire-v2.2.0" appears un-documented
... (27 total)
Fix:

LONG_LINE: For qcom,ports-* SoundWire arrays, these are inherently long due to the data format. Either wrap them (if possible without losing readability) or accept as a known DT style issue. Many upstream Qualcomm DTS files carry similar warnings.

UNDOCUMENTED_DT_STRING: Add binding YAML files for each new qcom,kaanapali-* compatible string, or add the strings as additional compatibles in existing bindings. The qcom,soundwire-v2.2.0 string should be documented in the SoundWire binding.

Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 6964936c9bfc..17cb9a3b3b78

❌ check-patch-compliance

Root cause: Commit f05f20f41481 ("FROMLIST: arm64: dts: qcom: kaanapali: Add camss node") has a Link: tag pointing to lore, but the patch content in the PR differs from the upstream mbox.

Failure details:
Checking commit: FROMLIST: arm64: dts: qcom: kaanapali: Add camss node
Change is different from the one mentioned in Link
The commit carries:
Link: https://lore.kernel.org/all/20260508-knp-camera-v1-1-a18e289163fd@oss.qualcomm.com/
The checker fetched the upstream mbox and found the diff does not match. This is consistent with the dtb-check failure — the patch as applied has a structural DTS error (properties placed outside their node) that is likely an adaptation or rebase artifact not present in the upstream posting.

Fix:

Fetch the upstream patch: b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260508-knp-camera-v1-1-a18e289163fd@oss.qualcomm.com/ -o /tmp/out

Compare diffs: diff <(git format-patch -1 f05f20f41481 --stdout | grep -E '^[+-][^+-]') <(grep -E '^[+-][^+-]' /tmp/out/*.mbx)

The mismatch is almost certainly the misplaced properties at line 728 — fixing the dtb-check issue (moving properties to the correct node) should also resolve this content-mismatch.

Reproduce locally:
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260508-knp-camera-v1-1-a18e289163fd@oss.qualcomm.com/ -o /tmp/out

Verdict

3 blockers to fix before merge, all in commit f05f20f41481 ("FROMLIST: arm64: dts: qcom: kaanapali: Add camss node"):

dtb-check [BLOCKER] — Fix the DTS structure error: properties at kaanapali.dtsi:728 are placed after a subnode boundary. Move them inside the correct parent node.

check-patch-compliance [BLOCKER] — Fixing the DTS structure error above should also resolve the content-mismatch with the upstream lore link.

checkpatch [WARNING] — 29 LONG_LINE and 27 UNDOCUMENTED_DT_STRING warnings. The long lines in SoundWire port arrays are difficult to avoid; the undocumented compatible strings should be addressed by adding/updating binding YAML files (or accepted as known limitations for a new SoC bring-up patch).

shashim-quic

Intake review

All commit-level checks pass (FROMLIST prefix ✓, Link: tags ✓, author/committer domains ✓, diff clean ✓).

Missing `CRs-Fixed:` in PR description

The PR body does not contain a CRs-Fixed: <number> line. Please add the CR tracking number before merging.

HangxiangMa added 8 commits May 19, 2026 01:34

HangxiangMa requested review from a team, knaveen-qc, quicAspratap and rrnayak May 19, 2026 08:40

shashim-quic requested changes May 19, 2026

View reviewed changes

HangxiangMa closed this May 19, 2026

HangxiangMa deleted the camss-knp-topics branch May 19, 2026 11:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kaanapali camss#597

Kaanapali camss#597
HangxiangMa wants to merge 8 commits into
qualcomm-linux:qcom-6.18.yfrom
HangxiangMa:camss-knp-topics

HangxiangMa commented May 19, 2026

Uh oh!

qswat-orbit-external Bot commented May 19, 2026

Uh oh!

knaveen-qc commented May 19, 2026

🔍 Patch Validation Report

Commit Summary

Commit Message Checks

Diff Comparison

Upstream Patch Status

Dependency Check

qcom-next Presence

Issues Found

Verdict

Final Summary

Uh oh!

knaveen-qc commented May 19, 2026

🤖 CI Checker Analysis (checker-log-analyzer)

❌ dtb-check

❌ checkpatch

❌ check-patch-compliance

Verdict

Uh oh!

shashim-quic left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

HangxiangMa commented May 19, 2026

Uh oh!

qswat-orbit-external Bot commented May 19, 2026

Uh oh!

knaveen-qc commented May 19, 2026

PR #597 — validate-patch

🔍 Patch Validation Report

Commit Summary

Commit Message Checks

Diff Comparison

Upstream Patch Status

Dependency Check

qcom-next Presence

Issues Found

Verdict

Final Summary

Uh oh!

knaveen-qc commented May 19, 2026

PR #597 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ dtb-check

❌ checkpatch

❌ check-patch-compliance

Verdict

Uh oh!

shashim-quic left a comment

Choose a reason for hiding this comment

Intake review

Missing CRs-Fixed: in PR description

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Missing `CRs-Fixed:` in PR description