Skip to content

QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path#638

Open
cjha01 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
cjha01:purwa_fw_dt_change
Open

QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path#638
cjha01 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
cjha01:purwa_fw_dt_change

Conversation

@cjha01
Copy link
Copy Markdown

@cjha01 cjha01 commented Jun 1, 2026

Update the path for the camera icp firmware.

CRs-Fixed: 4555859

Update the path for the camera icp firmware.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
@cjha01 cjha01 requested review from a team, quic-tingweiz, rrnayak and trsoni June 1, 2026 11:15
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4555859 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4555859
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis
Copy link
Copy Markdown

PR #638 — validate-patch

PR: #638

Verdict Issues Detailed Report
N/A 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: N/A — click to expand

🔍 Patch Validation

PR: #638 - QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path
Upstream commit: N/A (vendor-only commit)
Verdict: ⏭️ NOT APPLICABLE (vendor-only change)

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix — no upstream source
Body preserves rationale Brief but clear: updates camera ICP firmware path
Fixes tag present/correct N/A Not a bug fix
Authorship preserved Author and Signed-off-by consistent
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa-camera.dtsi Single-line change: firmware path x1p4x100x1p42100

Issues

None. This is a vendor-specific configuration change with no upstream equivalent.

Verdict

Not applicable for lore validation. This commit uses the QCLINUX: prefix, which by design indicates a vendor-only change that is not posted to upstream mailing lists and has no lore.kernel.org source to validate against. The change itself is straightforward: updating a camera firmware path from qcom/x1p4x100/CAMERA_ICP to qcom/x1p42100/CAMERA_ICP.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis
Copy link
Copy Markdown

PR #638 — checker-log-analyzer

PR: #638
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26751615143

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check DTB validation passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance QCLINUX: prefix not accepted
tag-check ⚠️ QCLINUX: is valid for tag-check but fails compliance

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #638 - QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26751615143
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check DTB validation passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance QCLINUX: prefix not accepted
tag-check ⚠️ QCLINUX: is valid for tag-check but fails compliance

❌ check-patch-compliance

Root cause: The commit uses QCLINUX: prefix, which is not in the allowed list for check-patch-compliance.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Change Purwa camera firmware path
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker enforces a strict subset of prefixes and only accepts:

  • FROMLIST: — patch posted to mailing list
  • FROMGIT: — patch from maintainer tree
  • UPSTREAM: — patch merged into mainline
  • BACKPORT: — upstream patch with modifications

The commit uses QCLINUX:, which is a vendor-internal prefix used for changes with no upstream equivalent. This is a known limitation of the checker — it always fails for vendor-only commits.

Context:

This is a vendor-specific DTS change updating a camera firmware path from qcom/x1p4x100/CAMERA_ICP to qcom/x1p42100/CAMERA_ICP. This change:

  • Has no upstream equivalent (vendor board file)
  • Is not posted to any mailing list
  • Cannot use FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT: prefixes

Options:

  1. Accept the checker failure — This is a known limitation for vendor-only commits. The QCLINUX: prefix is correct for this type of change, and the checker will always fail. The commit itself is valid.

  2. Remove the prefix entirely — Change subject to just arm64: dts: qcom: Change Purwa camera firmware path (no prefix). However, this violates the tag-check requirement for branches other than qcom-next/qcom-next-staging.

  3. Use a different workflow — Vendor-only commits like this may need to bypass check-patch-compliance or use a different review process.

Recommendation: Accept the checker failure as a known limitation. The commit is correctly tagged with QCLINUX: for a vendor-only change.

Reproduce locally:

cd kernel
git log b7cce9a3884a..0aae77f00120 --format="%H %s"
# Verify the prefix

Verdict

1 known limitation — The check-patch-compliance checker fails for QCLINUX: prefixed commits by design. This is a vendor-only DTS change with no upstream equivalent, so the failure is expected and acceptable. The commit is correctly formatted and passes all other checks.

Recommendation: Merge as-is. The checker failure is a known limitation for vendor-only commits and does not indicate a defect in the patch.

@qcomlnxci
Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ⚠️ skip ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants