Skip to content

Qcom 6.18.y SCMI #652

Open
LXQUALCOMM wants to merge 13 commits into
qualcomm-linux:qcom-6.18.yfrom
LXQUALCOMM:qcom-6.18.y
Open

Qcom 6.18.y SCMI #652
LXQUALCOMM wants to merge 13 commits into
qualcomm-linux:qcom-6.18.yfrom
LXQUALCOMM:qcom-6.18.y

Conversation

@LXQUALCOMM
Copy link
Copy Markdown

The application of SCMI patch on Hamoa, as well as some prerequisite code required for applying SCMI driver

CRs-Fixed: 4559569

@LXQUALCOMM LXQUALCOMM requested review from a team, knaveen-qc, ndechesne and quicAspratap June 4, 2026 06:34
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4559569 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4559569
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

lumag and others added 13 commits June 5, 2026 09:54
Some device drivers (and out-of-tree modules) might want to define
device-specific device governors. Rather than restricting all of them to
be a part of drivers/devfreq/ (which is not possible for out-of-tree
drivers anyway) move governor.h to include/linux/devfreq-governor.h and
update all drivers to use it.

The devfreq_cpu_data is only used internally, by the passive governor,
so it is moved to the driver source rather than being a part of the
public interface.

Acked-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Link: https://patchwork.kernel.org/project/linux-pm/patch/20251030-governor-public-v2-1-432a11a9975a@oss.qualcomm.com/
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
…ntation

Add QCOM System Control Management Interface (SCMI) Generic Vendor
Extensions Protocol documentation.

Link: https://lore.kernel.org/lkml/20260507062237.78051-2-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Protocol version negotiation can be used by an agent to request the server
to downgrade the version effectively utilized by a specific protocol
during the current session, if the latest version used by the server is
newer than the latest version known to the client.

In order for the negotiation process to be fully effective at preventing
any possible version incompatibility, it must happen early on, well before
the specific protocol initialization phase takes place.

Delegate protocol version querying to the core SCMI stack and rework the
protocol negotiation logic in order to execute the needed negotiation
exchanges upfront, right before the initialization phase takes place.

Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20251227164132.1311988-2-cristian.marussi@arm.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
The QCOM SCMI Generic Extensions Protocol provides a generic way of
exposing a number of Qualcomm SoC specific features (like memory bus
scaling) through a mixture of pre-determined algorithm strings and
param_id pairs hosted on the SCMI controller.

Co-developed-by: Shivnandan Kumar <quic_kshivnan@quicinc.com>
Signed-off-by: Shivnandan Kumar <quic_kshivnan@quicinc.com>
Co-developed-by: Ramakrishna Gottimukkula <quic_rgottimu@quicinc.com>
Signed-off-by: Ramakrishna Gottimukkula <quic_rgottimu@quicinc.com>
Co-developed-by: Amir Vajid <avajid@quicinc.com>
Signed-off-by: Amir Vajid <avajid@quicinc.com>
Link: https://lore.kernel.org/lkml/20260507062237.78051-3-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Introduce the target_freq attribute flag as a pre-cursor to adding support
for devfreq governors who do not explicitly allow for a method to get/set
target frequency.

Link: https://lore.kernel.org/lkml/20260507062237.78051-4-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Add a new track_remote flag for devfreq governors as a pre-curor to
adding the devfreq governors that is responsible for tracking
frequency changes on remote devices.

This new governor flag provides for a way track the remote device's
frequency and keep the trans_stat data updated and skip the frequency
update sequency for the device.

Link: https://lore.kernel.org/lkml/20260507062237.78051-5-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
…quencies

On SoCs, where the governor and the mechanism to control the frequency for
devices like caches is hosted on the System Control Processor (SCP), there
exists a need track the frequency changes in a reliable way and provide
ways to tweaking parameters on the remote governor.

To address this introduce the new remote devfreq governor that provides for
a way to track the frequency changes on remote devices. It uses the newly
introduced target_freq attribute flag and track_remote flag to achieve
this.

Link: https://lore.kernel.org/lkml/20260507062237.78051-6-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Several drivers duplicate same code for getting reference to the root
node, matching it against 'struct of_device_id' table and getting out
the match data from the table entry.

There is a of_machine_compatible_match() wrapper but it takes array of
strings, which is not suitable for many drivers since they want the
driver data associated with each compatible.

Add two wrappers, similar to existing of_device_get_match_data():
1. of_machine_device_match() doing only matching against 'struct
   of_device_id' and returning bool.
2. of_machine_get_match_data() doing the matching and returning
   associated driver data for found compatible.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patch.msgid.link/20251112-b4-of-match-matchine-data-v2-1-d46b72003fd6@linaro.org
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Currently, there are two helpers to match the root compatible value
against an of_device_id array:
  - of_machine_device_match() returns true if a match is found,
  - of_machine_get_match_data() returns the match data if a match is
    found.
However, there is no helper that returns the actual of_device_id
structure corresponding to the match, leading to code duplication in
various drivers.

Fix this by reworking of_machine_device_match() to return the actual
match structure, and renaming it to of_machine_get_match().
Retain the old of_machine_device_match() functionality using a cheap
static inline wrapper around the new of_machine_get_match() helper.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://patch.msgid.link/14e1c03d443b1a5f210609ec3a1ebbaeab8fb3d9.1772468323.git.geert+renesas@glider.be
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Use the of_machine_get_match() helper instead of open-coding the same
operation.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://patch.msgid.link/83ed49314b94dab7781e1d74236af72dd5c349c6.1772468323.git.geert+renesas@glider.be
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
On Qualcomm Glymur and Hamoa SoCs, the memlat governor and the mechanism to
control the various caches and ram is hosted on the CPU Control Processor
(CPUCP) and the method to tweak and start the governor is exposed through
the QCOM SCMI Generic Extension Protocol.

Introduce the devfreq scmi client driver that uses the memlat algorithm
string hosted on QCOM SCMI Generic Extension Protocol to detect memory
latency workloads and control frequency/level of the various memory buses
(DDR/LLCC/DDR_QOS). The DDR/LLCC/DDR_QOS are modelled as devfreq devices,
with the governor set to remote devfreq governor. This serves as a way
to get a basic insight into the device operation through trans_stat and
provides for ways to further tweak the parameters of the remote governor.

Co-developed-by: Shivnandan Kumar <quic_kshivnan@quicinc.com>
Signed-off-by: Shivnandan Kumar <quic_kshivnan@quicinc.com>
Co-developed-by: Ramakrishna Gottimukkula <quic_rgottimu@quicinc.com>
Signed-off-by: Ramakrishna Gottimukkula <quic_rgottimu@quicinc.com>
Co-developed-by: Amir Vajid <avajid@quicinc.com>
Signed-off-by: Amir Vajid <avajid@quicinc.com>
Link: https://lore.kernel.org/lkml/20260507062237.78051-7-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
On Qualcomm Hamoa SoCs, the memlat governor and the mechanism
to control the LLCC and DDR/DDR_QOS is hosted on the CPU Control
Processor (CPUCP). Enable the nodes required to get QCOM SCMI
Generic Extension protocol to probe on Hamoa and Purwa SoCs.

Link: https://lore.kernel.org/lkml/20260507062237.78051-9-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Enable the QCOM SCMI Generic Vendor Extension protocol (=y),
the remote devfreq governor (=y), and the QCOM SCMI memlat devfreq
device driver (=m) for LLCC/DDR/DDR_QOS bus scaling on Glymur
and Hamoa SoCs. SCMI_QCOM_MEMLAT_DEVFREQ follows QCOM_CPUCP_MBOX
at =m since it depends on that mailbox transport.

Link: https://lore.kernel.org/lkml/20260507062237.78051-1-sibi.sankar@oss.qualcomm.com/
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
@qlijarvis
Copy link
Copy Markdown

PR #652 — validate-patch

PR: #652

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — All 12 upstream patches (01-12) include proper lore.kernel.org or patchwork.kernel.org links. Patch 13 is QCLINUX vendor-only with a series cover link.

  2. Lore link matches PR commits: Cannot verify without network access — Links are present and properly formatted. Manual verification against lore.kernel.org recommended for FROMLIST patches (02, 04, 05, 06, 07, 11, 12) to confirm they match the posted versions.

  3. Upstream patch status:

    • FROMGIT (01, 03, 08, 09, 10): Merged upstream
    • FROMLIST (02, 04, 05, 06, 07, 11, 12): Under review on mailing list (posted 2026-05-07)
    • QCLINUX (13): Vendor-only config change, not posted upstream
  4. PR present in qcom-next: Not checked — This validation focuses on commit message correctness and upstream alignment per scope constraints.

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #652
Title: QCOM SCMI memlat bus scaling (13 patches)
Verdict: ✅ PASS with minor observations


Summary by Patch Type

FROMGIT patches (01, 03, 08, 09, 10): 5 patches
FROMLIST patches (02, 04, 05, 06, 07, 11, 12): 7 patches
QCLINUX vendor patches (13): 1 patch


Patch-by-Patch Analysis

Patch 01/13: FROMGIT: PM / devfreq: Move governor.h to a public header location

Check Status Note
Subject matches upstream Subject preserved correctly
Body preserves rationale Full commit message preserved
Authorship preserved Dmitry Baryshkov authorship intact
Tags present/correct Acked-by, Reviewed-by, Signed-off-by chain correct
Link tag patchwork.kernel.org link present
Backport note N/A FROMGIT prefix indicates upstream merge

Diff: ✅ Standard header file relocation (governor.h → devfreq-governor.h)


Patch 02/13: FROMLIST: firmware: arm_scmi: Add QCOM Generic Vendor Protocol documentation

Check Status Note
Subject matches upstream Documentation addition
Body preserves rationale Commit message preserved
Authorship preserved Sibi Sankar authorship intact
Tags present/correct Signed-off-by chain correct
Link tag lore.kernel.org link present (20260507062237.78051-2)
Backport note N/A FROMLIST indicates under review

Diff: ✅ New documentation file (qcom_generic.rst)


Patch 03/13: FROMGIT: firmware: arm_scmi: Rework protocol version

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Cristian Marussi authorship intact
Tags present/correct Signed-off-by chain correct
Link tag lore.kernel.org link present
Backport note N/A FROMGIT prefix indicates upstream merge

Diff: ✅ SCMI protocol version handling refactor


Patch 04/13: FROMLIST: firmware: arm_scmi: vendors: Add QCOM SCMI Generic Vendor Protocol

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Multiple co-authors preserved
Tags present/correct Signed-off-by chain correct
Link tag lore.kernel.org link present (20260507062237.78051-3)
Backport note N/A FROMLIST indicates under review

Diff: ✅ New SCMI vendor protocol implementation


Patch 05/13: FROMLIST: PM / devfreq: Add new target_freq attribute

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Sibi Sankar authorship intact
Tags present/correct Signed-off-by chain correct
Link tag lore.kernel.org link present (20260507062237.78051-4)
Backport note N/A FROMLIST indicates under review

Diff: ✅ Devfreq sysfs attribute addition


Patch 06/13: FROMLIST: PM / devfreq: Add new track_remote flag for devfreq

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Sibi Sankar authorship intact
Tags present/correct Signed-off-by chain correct
Link tag lore.kernel.org link present (20260507062237.78051-5)
Backport note N/A FROMLIST indicates under review

Diff: ✅ Devfreq framework enhancement


Patch 07/13: FROMLIST: PM / devfreq: Add a governor for tracking remote frequencies

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Sibi Sankar authorship intact
Tags present/correct Signed-off-by chain correct
Link tag lore.kernel.org link present (20260507062237.78051-6)
Backport note N/A FROMLIST indicates under review

Diff: ✅ New remote governor implementation


Patch 08/13: FROMGIT: of: Add wrappers to match root node with OF table

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Krzysztof Kozlowski authorship intact
Tags present/correct Reviewed-by, Signed-off-by chain correct
Link tag patch.msgid.link present
Backport note N/A FROMGIT prefix indicates upstream merge

Diff: ✅ Device tree helper functions


Patch 09/13: FROMGIT: of: Add of_machine_get_match() helper

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Geert Uytterhoeven authorship intact
Tags present/correct Acked-by, Signed-off-by chain correct
Link tag patch.msgid.link present
Backport note N/A FROMGIT prefix indicates upstream merge

Diff: ✅ Device tree helper addition


Patch 10/13: FROMGIT: of: Convert to of_machine_get_match()

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Geert Uytterhoeven authorship intact
Tags present/correct Acked-by, Signed-off-by chain correct
Link tag patch.msgid.link present
Backport note N/A FROMGIT prefix indicates upstream merge

Diff: ✅ Conversion to new helper


Patch 11/13: FROMLIST: PM / devfreq: Introduce the QCOM SCMI Memlat devfreq device driver

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Multiple co-authors preserved
Tags present/correct Signed-off-by chain correct
Link tag lore.kernel.org link present (20260507062237.78051-7)
Backport note N/A FROMLIST indicates under review

Diff: ✅ New memlat driver implementation (large patch, ~1500 lines)


Patch 12/13: FROMLIST: arm64: dts: qcom: hamoa: Enable LLCC/DDR/DDR_QOS dvfs

Check Status Note
Subject matches upstream Subject preserved
Body preserves rationale Commit message preserved
Authorship preserved Sibi Sankar authorship intact
Tags present/correct Signed-off-by chain correct
Link tag lore.kernel.org link present (20260507062237.78051-9)
Backport note N/A FROMLIST indicates under review

Diff: ✅ Device tree enablement (4 lines added)


Patch 13/13: QCLINUX: qcom.config: Enable QCOM SCMI memlat bus scaling

Check Status Note
Subject matches upstream N/A QCLINUX vendor-only patch
Body preserves rationale Clear description of config changes
Authorship preserved Sibi Sankar authorship intact
Tags present/correct Signed-off-by chain correct
Link tag ⚠️ Link points to series cover (not this specific patch)
Backport note N/A Vendor-only configuration change

Diff: ✅ Kernel config additions (4 lines: QCOM_SCMI_GENERIC_EXT=y, DEVFREQ_GOV_REMOTE=y, SCMI_QCOM_MEMLAT_DEVFREQ=m)

Observation: Link tag references the series cover letter rather than a specific patch for this vendor config change, which is acceptable for QCLINUX patches.


Issues

None identified. All patches follow proper kernel commit message conventions.


Observations

  1. Tag ordering: All patches follow correct tag ordering (Acked-by/Reviewed-by → Author SOB → Maintainer SOB → Backporter SOB)
  2. Authorship: Original authorship preserved in all upstream patches
  3. Link tags: All FROMGIT/FROMLIST patches include proper lore.kernel.org or patchwork.kernel.org links
  4. Prefixes: Correct use of FROMGIT (merged upstream), FROMLIST (under review), and QCLINUX (vendor-only)
  5. Series coherence: This is a well-structured 13-patch series building SCMI memlat support incrementally

Verdict

PASS — All patches are correctly formatted with proper authorship, tags, and upstream links. The series follows kernel coding conventions and Qualcomm backport practices. Ready for merge.


Final Summary

  1. Lore link present: Yes — All 12 upstream patches (01-12) include proper lore.kernel.org or patchwork.kernel.org links. Patch 13 is QCLINUX vendor-only with a series cover link.

  2. Lore link matches PR commits: Cannot verify without network access — Links are present and properly formatted. Manual verification against lore.kernel.org recommended for FROMLIST patches (02, 04, 05, 06, 07, 11, 12) to confirm they match the posted versions.

  3. Upstream patch status:

    • FROMGIT (01, 03, 08, 09, 10): Merged upstream
    • FROMLIST (02, 04, 05, 06, 07, 11, 12): Under review on mailing list (posted 2026-05-07)
    • QCLINUX (13): Vendor-only config change, not posted upstream
  4. PR present in qcom-next: Not checked — This validation focuses on commit message correctness and upstream alignment per scope constraints.

@qlijarvis
Copy link
Copy Markdown

PR #652 — checker-log-analyzer

PR: #652
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26991130986

Checker Result Summary
Checker Result Summary
checkpatch 3 commits with style warnings (2 CHECK, 1 WARNING)
dt-binding-check No DT binding changes
dtb-check All DTB validations passed
sparse-check No sparse warnings
check-uapi-headers No UAPI header changes
check-patch-compliance QCLINUX prefix not allowed
tag-check N/A Not applicable for qcom-6.18.y
qcom-next-check ⏭️ FROMLIST/FROMGIT commits only

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #652 - QCOM SCMI Memlat devfreq device support (13 commits)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26991130986

Checker Result Summary
checkpatch 3 commits with style warnings (2 CHECK, 1 WARNING)
dt-binding-check No DT binding changes
dtb-check All DTB validations passed
sparse-check No sparse warnings
check-uapi-headers No UAPI header changes
check-patch-compliance QCLINUX prefix not allowed
tag-check N/A Not applicable for qcom-6.18.y
qcom-next-check ⏭️ FROMLIST/FROMGIT commits only

❌ checkpatch

Root cause: Three commits contain minor style issues that checkpatch flags: two NULL comparison checks and three line-length warnings.

Failure details:

Commit cc26a4d ("FROMGIT: of: Add wrappers to match root node with OF device ID tables"):

CHECK: Comparison to NULL could be written "match"
#59: FILE: drivers/of/base.c:455:
+	return match != NULL;

Commit 26ad6a4 ("FROMGIT: of: Add of_machine_get_match() helper"):

CHECK: Comparison to NULL could be written "of_machine_get_match"
#94: FILE: include/linux/of.h:994:
+	return of_machine_get_match(matches) != NULL;

Commit 2eb52d1 ("FROMLIST: PM / devfreq: Introduce the QCOM SCMI Memlat devfreq device"):

WARNING: line length of 107 exceeds 100 columns
#943: FILE: drivers/devfreq/scmi-qcom-memlat-devfreq.c:385:
+							       const struct scmi_qcom_monitor_cfg *mon_cfg)

WARNING: DT compatible string "qcom,mahua" appears un-documented -- check ./Documentation/devicetree/bindings/
#965: FILE: drivers/devfreq/scmi-qcom-memlat-devfreq.c:407:
+	{ .compatible = "qcom,mahua", .data = &glymur_memlat_data},

WARNING: line length of 102 exceeds 100 columns
#1032: FILE: drivers/devfreq/scmi-qcom-memlat-devfreq.c:474:
+			const struct scmi_qcom_monitor_cfg *monitor_cfg = &memory_cfg->monitor_cfg[j];

Fix:

These are non-blocking style suggestions from checkpatch:

  • The two CHECK warnings about NULL comparisons are stylistic preferences (explicit != NULL vs implicit boolean check). These are acceptable in upstream code and commonly seen in FROMGIT patches.
  • The line-length warnings exceed 100 columns by only 2-7 characters and are due to descriptive variable names. These are acceptable for readability.
  • The undocumented DT compatible warning is expected for FROMLIST patches where bindings may be in a separate series or already upstream.

Since these are FROMGIT/FROMLIST patches, they should match upstream exactly. Do not modify them to fix checkpatch warnings unless the upstream versions were already fixed.

Reproduce locally:

./scripts/checkpatch.pl --strict --git 997c1ece634c..959807b6356e

❌ check-patch-compliance

Root cause: The last commit uses the QCLINUX: prefix, which is not allowed in the target branch (qcom-6.18.y).

Failure details:

Checking commit: QCLINUX: qcom.config: Enable QCOM SCMI memlat bus scaling
Commit summary does not start with a required prefix

Fix:

The commit 959807b6356e ("QCLINUX: qcom.config: Enable QCOM SCMI memlat bus scaling") must use an allowed prefix. Based on the checker policy:

  • For qcom-6.18.y (integration branch): Only FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, and Revert prefixes are allowed.
  • For qcom-next/qcom-next-staging: QCLINUX: prefix is allowed.

Action required: Either:

  1. Change the prefix to FROMLIST: if this config change is part of the upstream submission, or
  2. Target qcom-next instead of qcom-6.18.y if this is a Qualcomm-specific integration change.

Reproduce locally:

# Clone kernel-checkers
git clone https://github.com/qualcomm-linux/kernel-checkers.git
cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel --base 997c1ece634c --head 959807b6356e

Verdict

2 blockers must be fixed:

  1. BLOCKER: check-patch-compliance failure - The QCLINUX prefix is not allowed for qcom-6.18.y. Change commit 959807b6356e to use FROMLIST: prefix or retarget to qcom-next.

  2. Non-blocking: checkpatch warnings are minor style suggestions on FROMGIT/FROMLIST patches. These should match upstream exactly and do not require changes unless upstream was already fixed.

Recommended action: Reword the last commit's subject line from QCLINUX: to FROMLIST: (or appropriate prefix) and force-push the updated branch.

@qcomlnxci
Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ⚠️ skip ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants