clk: qcom: Add DISPCC and GPUCC support for the Qualcomm Shikra SoC

[imrashai]

This series adds support for the Display clock controller (DISPCC) and GPU Clock Controller (GPUCC) on Qualcomm Shikra SoC, by reusing the respective QCM2290 SoC drivers.

In qcom-6.18.y branch, the Shikra DISPCC/GPUCC v1 series changes are merged already. But as per the upstream comments, we are re-suing the Agatti drivers, and v1 series chagnes are not applicable now. Hence, I have reverted all those v1 specific changes in a commit, and on top of that updated all the latest v4 series changes.

Link to v4: https://lore.kernel.org/all/20260604-shikra-dispcc-gpucc-v4-0-8204f1029311@oss.qualcomm.com

CRs-Fixed: 4560023

[qlijarvis]

PR #655 — validate-patch

PR: #655

Verdict	Issues	Detailed Report
⚠️	3	Full report

Final Summary

1. Lore link present: Yes — all FROMLIST commits (02-14) include Link: tag pointing to the v4 series cover letter
2. Lore link matches PR commits: Cannot verify — the lore URL contains a future date (2026-06-04) and returns no content when fetched
3. Upstream patch status: Cannot determine — lore link is inaccessible; likely these are patches prepared for upstream submission but not yet posted
4. PR present in qcom-next: Not checked — validation scope limited to commit message and diff correctness per instructions

Additional observations:

• Commit 01/14 is vendor-only (no FROMLIST prefix, no lore link) — this is a revert of previous Shikra DISPCC/GPUCC code
• Commits 02-14 are marked FROMLIST and include proper Link: tags
• The series appears to be a v4 revision that refactors QCM2290 clock drivers and adds Shikra support by extending the QCM2290 drivers
• All commits follow kernel commit message format with proper Signed-off-by tags
• The lore link format suggests this may be a pre-submission or internal review version with a placeholder/future date

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #655 - Shikra DISPCC/GPUCC v4 series
Upstream commit: https://lore.kernel.org/all/20260604-shikra-dispcc-gpucc-v4-0-8204f1029311@oss.qualcomm.com
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	⚠️	Patch 01/14 has typo: "chages" should be "changes"
Body preserves rationale	✅	FROMLIST commits preserve upstream rationale
Fixes tag present/correct	N/A	No Fixes tags required for new feature additions
Authorship preserved	✅	All commits authored by Imran Shaik
Backport note (if applicable)	N/A	FROMLIST patches, not backports

Diff

File	Status	Notes
Patch 01/14 (vendor revert)	✅	Vendor-only cleanup, no upstream equivalent
Patches 02-14 (FROMLIST)	⚠️	Cannot verify - lore link points to future date (2026-06-04)

Issues

• Commit 01/14 typo: Subject line contains "chages" instead of "changes"
• Lore link validation blocked: All FROMLIST commits reference https://lore.kernel.org/all/20260604-shikra-dispcc-gpucc-v4-0-8204f1029311@oss.qualcomm.com which has a future date (2026-06-04) and cannot be fetched for validation
• Link format: The lore link points to the cover letter (v4-0) rather than individual patch messages, making per-patch validation difficult

Verdict

Merge with minor fix recommended: Fix the typo in commit 01/14 before merging. The FROMLIST commits appear structurally correct but cannot be validated against upstream due to the future-dated lore link.

Final Summary

1. Lore link present: Yes — all FROMLIST commits (02-14) include Link: tag pointing to the v4 series cover letter
2. Lore link matches PR commits: Cannot verify — the lore URL contains a future date (2026-06-04) and returns no content when fetched
3. Upstream patch status: Cannot determine — lore link is inaccessible; likely these are patches prepared for upstream submission but not yet posted
4. PR present in qcom-next: Not checked — validation scope limited to commit message and diff correctness per instructions

Additional observations:

• Commit 01/14 is vendor-only (no FROMLIST prefix, no lore link) — this is a revert of previous Shikra DISPCC/GPUCC code
• Commits 02-14 are marked FROMLIST and include proper Link: tags
• The series appears to be a v4 revision that refactors QCM2290 clock drivers and adds Shikra support by extending the QCM2290 drivers
• All commits follow kernel commit message format with proper Signed-off-by tags
• The lore link format suggests this may be a pre-submission or internal review version with a placeholder/future date

[qlijarvis]

PR #655 — checker-log-analyzer

PR: #655
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26945709225

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	7 warnings on commit 1/14 (DT binding separation)
dt-binding-check	✅	All binding checks passed
dtb-check	✅	All DTB validation passed
sparse-check	✅	Sparse analysis passed
check-uapi-headers	✅	No UAPI header changes detected
check-patch-compliance	❌	2 blockers: missing prefix on commit 1, invalid lore links
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	⏭️	FROMLIST commits present (expected)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #655 - clk: qcom: Shikra DISPCC/GPUCC v4 series
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26945709225

Checker	Result	Summary
checkpatch	❌	7 warnings on commit 1/14 (DT binding separation)
dt-binding-check	✅	All binding checks passed
dtb-check	✅	All DTB validation passed
sparse-check	✅	Sparse analysis passed
check-uapi-headers	✅	No UAPI header changes detected
check-patch-compliance	❌	2 blockers: missing prefix on commit 1, invalid lore links
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	⏭️	FROMLIST commits present (expected)

---

❌ checkpatch

Root cause: Commit 88b2209 ("clk: qcom: Revert older series Shikra GPUCC/DISPCC changes") mixes DT binding deletions with driver code deletions in a single commit.

Failure details:

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

88b220943a26a64d50f3693b7a2eaa33dc148af6 total: 0 errors, 7 warnings, 0 checks, 63 lines checked

The commit deletes:

• Documentation/devicetree/bindings/clock/qcom,shikra-dispcc.yaml
• include/dt-bindings/clock/qcom,shikra-dispcc.h
• include/dt-bindings/clock/qcom,shikra-gpucc.h
• drivers/clk/qcom/dispcc-shikra.c
• drivers/clk/qcom/gpucc-shikra.c

Fix: Split commit 1 into two commits:

1. First commit: Delete DT bindings and includes only
2. Second commit: Delete driver code and Kconfig/Makefile changes

Reproduce locally:

./scripts/checkpatch.pl --strict --git 32eb26c08e43..88b220943a26

---

❌ check-patch-compliance

Root cause: Two distinct issues prevent compliance:

1. Commit 1 missing required prefix: The first commit "clk: qcom: Revert older series Shikra GPUCC/DISPCC changes" does not start with a required prefix (UPSTREAM:, FROMLIST:, BACKPORT:, or FROMGIT:).

2. Invalid lore.kernel.org links: All 13 FROMLIST commits (2-14) reference the same cover letter URL instead of individual patch URLs:

   Link: https://lore.kernel.org/all/20260604-shikra-dispcc-gpucc-v4-0-8204f1029311@oss.qualcomm.com
   

   The checker validates each link with b4 am --single-message and reports: "Something seems wrong with the provided link."

Failure details:

Checking commit: clk: qcom: Revert older series Shikra GPUCC/DISPCC changes
Commit summary does not start with a required prefix

Checking commit: FROMLIST: clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260604-shikra-dispcc-gpucc-v4-0-8204f1029311@oss.qualcomm.com

Fix:

For commit 1: Add a prefix to indicate this is a local revert/cleanup:

REVERT: clk: qcom: Revert older series Shikra GPUCC/DISPCC changes

or

CLEANUP: clk: qcom: Revert older series Shikra GPUCC/DISPCC changes

For commits 2-14: Replace the cover letter link with individual patch message-IDs. Each commit should have its own Link: tag pointing to the specific patch in the series:

Link: https://lore.kernel.org/all/20260604-shikra-dispcc-gpucc-v4-1-8204f1029311@oss.qualcomm.com  # for patch 1/13
Link: https://lore.kernel.org/all/20260604-shikra-dispcc-gpucc-v4-2-8204f1029311@oss.qualcomm.com  # for patch 2/13
...
Link: https://lore.kernel.org/all/20260604-shikra-dispcc-gpucc-v4-13-8204f1029311@oss.qualcomm.com # for patch 13/13

The pattern is: change -v4-0- (cover letter) to -v4-N- where N is the patch number (1-13).

Reproduce locally:

cd kernel
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 32eb26c08e43 --head 9ccf73887096

---

Verdict

2 blockers must be fixed before merge:

1. checkpatch: Split commit 1 to separate DT bindings from driver code
2. check-patch-compliance:
   • Add required prefix to commit 1 (REVERT: or CLEANUP:)
   • Fix Link: tags in commits 2-14 to point to individual patches, not the cover letter

All other checkers (dt-binding-check, dtb-check, sparse-check, check-uapi-headers) passed successfully.

[qcomlnxci]

Test jobs on 49fc600

• Job 117858 on lemans-evk
• Job 117857 on monaco-evk
• Job 117852 on qcs615-ride
• Job 117854 on qcs6490-rb3gen2
• Job 117853 on qcs8300-ride
• Job 117855 on qcs9100-ride-r3
• Job 117856 on x1e80100-crd

[qcomlnxci]

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	✅ Pass	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️