QCLINUX: arm64: dts: qcom: Add Purwa sensors support

[shubammm]

Add og0va1b IR/VGA camera sensor node.
Add imx688 camera sensor node

CRs-Fixed: 4561668

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4561668 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561668
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4561668 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561668
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qlijarvis]

PR #662 — validate-patch

PR: #662

Verdict	Issues	Detailed Report
⚠️	3	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #662 - QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Upstream commit: N/A (vendor-only)
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-only commit (QCLINUX: prefix)
Body preserves rationale	⚠️	Minimal description; lacks hardware context
Fixes tag present/correct	N/A	New feature, not a fix
Authorship preserved	✅	Author: shubamm shubamm@qti.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi	✅	New sensor definitions for og0va1b and imx688
arch/arm64/boot/dts/qcom/purwa-evk-camx.dtso	✅	Includes new sensor file

Issues

• Commit message clarity: The body mentions "og0va1b IR/VGA camera sensor" but the DT node comment says "cam1-og0a1b" (typo: og0va1b vs og0a1b)
• Change-Id present: Gerrit Change-Id tag is included; typically removed for upstream-bound patches, but acceptable for vendor trees
• Minimal rationale: Commit body could benefit from brief hardware context (e.g., "Add camera sensor support for Purwa EVK platform")

Verdict

Acceptable for vendor tree merge with minor naming inconsistency between commit message and code comment.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

[qlijarvis]

PR #662 — checker-log-analyzer

PR: #662
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27007299289

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 error (Change-Id), 3 warnings (undocumented compatibles)
dt-binding-check	✅	No DT binding changes
dtb-check	❌	Duplicate node definitions causing FDT_ERR_NOTFOUND
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Missing required subject prefix (UPSTREAM:/FROMLIST:)
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #662 - QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27007299289

Checker	Result	Summary
checkpatch	❌	1 error (Change-Id), 3 warnings (undocumented compatibles)
dt-binding-check	✅	No DT binding changes
dtb-check	❌	Duplicate node definitions causing FDT_ERR_NOTFOUND
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Missing required subject prefix (UPSTREAM:/FROMLIST:)
tag-check	N/A	Not applicable for qcom-6.18.y branch
qcom-next-check	N/A	Not applicable for qcom-6.18.y branch

---

❌ checkpatch

Root cause: Gerrit Change-Id present in commit message (line 9) and undocumented DT compatible strings.

Failure details:

ERROR: Remove Gerrit Change-Id's before submitting upstream
#9: 
Change-Id: Ic416292cb290a6287244dcd5a088180b2e290bc9

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#34: FILE: arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:12:
+		compatible = "qcom,cam-sensor";

WARNING: DT compatible string "qcom,cam-res-mgr" appears un-documented -- check ./Documentation/devicetree/bindings/
#108: FILE: arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:86:
+		compatible = "qcom,cam-res-mgr";

Fix:

1. Remove the Change-Id: Ic416292cb290a6287244dcd5a088180b2e290bc9 line from the commit message
2. The undocumented compatible warnings are acceptable for vendor-specific downstream patches (QCLINUX prefix indicates this is not for upstream submission)

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git HEAD~1..HEAD

---

❌ dtb-check

Root cause: Duplicate node definitions for &cam_cci0 and &cam_cci1 — both purwa-camera.dtsi and the new purwa-camera-sensor.dtsi define child nodes under these references, causing DTC to fail overlay application.

Failure details:

also defined at ../arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:8.11-43.3
also defined at ../arch/arm64/boot/dts/qcom/purwa-camera-sensor.dtsi:45.11-82.3

Failed to apply 'arch/arm64/boot/dts/qcom/purwa-evk-camx.dtbo': FDT_ERR_NOTFOUND
make[4]: *** [../scripts/Makefile.dtbs:85: arch/arm64/boot/dts/qcom/purwa-evk-camx.dtb] Error 1

The error indicates that purwa-camera.dtsi already defines &cam_cci0 and &cam_cci1 nodes (lines 489 and 586), and the new purwa-camera-sensor.dtsi is attempting to define them again (lines 8 and 45). When both files are included in purwa-evk-camx.dtso, the DTC compiler encounters duplicate definitions and fails to apply the overlay.

Fix:
The sensor nodes in purwa-camera-sensor.dtsi should be added as children inside the existing &cam_cci0 and &cam_cci1 references, not as new top-level references. The structure should be:

&cam_cci0 {
    qcom,cam-sensor1 {
        // sensor properties
    };
};

However, if purwa-camera.dtsi already defines the CCI nodes with their own structure, you need to either:

1. Add the sensor nodes directly to purwa-camera.dtsi instead of creating a separate file, OR
2. Ensure purwa-camera-sensor.dtsi uses unique child node names that don't conflict with existing definitions

Check what's already defined in purwa-camera.dtsi at lines 489-584 (cam_cci0) and 586-681 (cam_cci1) to understand the existing structure.

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) CHECK_DTBS=y qcom/purwa-evk-camx.dtb

---

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix for the qcom-6.18.y branch.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Add Purwa sensors support
Commit summary does not start with a required prefix

Fix:
For patches targeting qcom-6.18.y (a stable/release branch), commits should use one of these prefixes:

• UPSTREAM: - if the patch is already merged in mainline Linux
• FROMLIST: - if the patch is posted to a mailing list but not yet merged
• BACKPORT: - if the patch is a backport with modifications

Since this appears to be a new downstream-only patch (QCLINUX prefix), it may not be appropriate for qcom-6.18.y. Consider:

1. If this is truly downstream-only, target qcom-next or qcom-next-staging instead
2. If this is based on an upstream patch, change the prefix to UPSTREAM: or FROMLIST: and include the appropriate Link: tag

Reproduce locally:

# Check if commit follows compliance rules
git log --oneline -1
# Should start with UPSTREAM:, FROMLIST:, or BACKPORT: for stable branches

---

Verdict

3 blockers must be fixed before merge:

1. Critical: Remove Gerrit Change-Id from commit message
2. Critical: Fix duplicate DT node definitions causing dtb-check build failure
3. Critical: Add appropriate subject prefix (UPSTREAM:/FROMLIST:) or retarget to qcom-next branch

The DT compatible warnings are acceptable for downstream patches but the duplicate node issue will prevent the DTB from building successfully.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4561668 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561668
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.