Skip to content

QCLINUX: prune.config: Enable the TI DP83867 PHY driver#769

Merged
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
ayaan-anwar:ti_phy_config
Jun 24, 2026
Merged

QCLINUX: prune.config: Enable the TI DP83867 PHY driver#769
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
ayaan-anwar:ti_phy_config

Conversation

@ayaan-anwar

Copy link
Copy Markdown
Contributor

The Shikra EVK boards have an RGMII TI PHY connected to the dual EMACs of the SoC. Remove its config from prune.config to enable its driver.

CRs-Fixed: 4582518
QLI 0.0 PR: qualcomm-linux/kernel-topics#1399

The Shikra EVK boards have an RGMII TI PHY connected to the dual EMACs
of the SoC. Remove its config from prune.config to enable its driver.

Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #769 — validate-patch

PR: #769

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Additional Notes:

  • The change removes a prune.config entry to enable the TI DP83867 PHY driver (CONFIG_DP83867_PHY)
  • Rationale is hardware-specific: Shikra EVK boards use RGMII TI PHY connected to dual EMACs
  • prune.config is a Qualcomm-specific kernel configuration fragment used to disable unnecessary drivers
  • Removing the disable line allows the driver to be built when prune.config is applied
  • Commit message follows kernel style and provides sufficient context
  • No issues detected with authorship, sign-off, or diff integrity
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #769 - QCLINUX: prune.config: Enable the TI DP83867 PHY driver
Upstream commit: N/A (vendor-only)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only; QCLINUX: prefix correct
Body preserves rationale Clear explanation: Shikra EVK RGMII TI PHY support
Fixes tag present/correct N/A Not a bug fix; no Fixes tag needed
Authorship preserved Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com
Backport note (if applicable) N/A Vendor-only change, not a backport

Diff

File Status Notes
arch/arm64/configs/prune.config Single line removal; enables CONFIG_DP83867_PHY driver

Verdict

Merge as-is — vendor-only configuration change is correctly formatted with clear rationale for Shikra EVK hardware support.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Additional Notes:

  • The change removes a prune.config entry to enable the TI DP83867 PHY driver (CONFIG_DP83867_PHY)
  • Rationale is hardware-specific: Shikra EVK boards use RGMII TI PHY connected to dual EMACs
  • prune.config is a Qualcomm-specific kernel configuration fragment used to disable unnecessary drivers
  • Removing the disable line allows the driver to be built when prune.config is applied
  • Commit message follows kernel style and provides sufficient context
  • No issues detected with authorship, sign-off, or diff integrity

@qlijarvis

Copy link
Copy Markdown

PR #769 — checker-log-analyzer

PR: #769
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28099919877

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check ⏭️ Skipped - no code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Subject prefix validation failed
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable (QCLINUX commit)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #769 - QCLINUX: prune.config: Enable the TI DP83867 PHY driver
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28099919877

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no devicetree changes
sparse-check ⏭️ Skipped - no code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Subject prefix validation failed
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable (QCLINUX commit)

❌ check-patch-compliance

Root cause: Commit subject "QCLINUX: prune.config: Enable the TI DP83867 PHY driver" does not start with a required prefix for patch compliance.

Failure details:

2026-06-24T13:10:01.6285941Z Checking commit: QCLINUX: prune.config: Enable the TI DP83867 PHY driver
2026-06-24T13:10:01.6302487Z Commit summary does not start with a required prefix
2026-06-24T13:10:01.6317791Z ##[error]Process completed with exit code 1.

Fix: The check-patch-compliance checker enforces that commit subjects must start with one of the following prefixes:

  • UPSTREAM: - for commits already merged in mainline Linux
  • FROMLIST: - for commits posted to upstream mailing lists but not yet merged
  • BACKPORT: - for commits backported from another kernel version
  • FROMGIT: - for commits cherry-picked from another git tree

Since this is a Qualcomm-specific configuration change (enabling a driver in prune.config), and it's not from upstream, the commit subject should be changed to remove the QCLINUX: prefix and use a standard kernel subsystem prefix instead. However, if this is truly a downstream-only change, you have two options:

  1. Option 1 (Recommended): Use a proper subsystem prefix without QCLINUX:

    arm64: configs: prune: Enable the TI DP83867 PHY driver
    
  2. Option 2: If the checker allows downstream tags, check if there's an exemption mechanism for internal-only commits, or update the checker configuration to allow QCLINUX: prefix.

Reproduce locally:

cd /path/to/kernel
git fetch origin
bash /path/to/kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base 0c79596f52a5d047657e625aef7ed5a5beb90b4c \
  --head 49c205d7e253038297a5b36b17eaf19b5c8e8cf7

Verdict

1 blocker to fix: The commit subject must be updated to use a compliant prefix. Change from QCLINUX: prune.config: Enable the TI DP83867 PHY driver to arm64: configs: prune: Enable the TI DP83867 PHY driver (or use an appropriate UPSTREAM:/FROMLIST:/BACKPORT: prefix if applicable).

@ayaan-anwar

Copy link
Copy Markdown
Contributor Author

Validation result:
Retail - boot up, ethernet0 pings
Industrial - boot up, ethernet0 pings

@ayaan-anwar

Copy link
Copy Markdown
Contributor Author

qli-2.0 GA Critical Fix

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ◻️ ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ◻️ ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@sgaud-quic Salendarsingh Gaud (sgaud-quic) merged commit 3bb7525 into qualcomm-linux:qcom-6.18.y Jun 24, 2026
6 of 8 checks passed
@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ◻️ ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ◻️ ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ◻️ ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ◻️ ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants