FROMLIST: arm64: dts: qcom: shikra: Add missing CPU OPPs

[Komal Bajaj (Komal-Bajaj)]

Add the 2.208 GHz operating point to the CPU0 and CPU3 OPP tables, and add the 768 MHz operating point to the CPU3 table.

This keeps the Shikra CPU OPP tables aligned with the supported frequency set.

Link: https://lore.kernel.org/all/20260702-shikra-dt-m1-v5-4-f911ac92720c@oss.qualcomm.com/

CRs-Fixed: 4593076

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qlijarvis]

PR #804 — validate-patch

PR: #804

Verdict	Issues	Detailed Report
N/A	0	Full report

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260702-shikra-dt-m1-v5-4-f911ac92720c@oss.qualcomm.com/
2. Lore link matches PR commits: Cannot verify — network restrictions prevent fetching upstream patch for comparison
3. Upstream patch status: Unknown — manual verification required at lore.kernel.org (check for maintainer replies: applied/queued/Reviewed-by/Acked-by = accepted; NAK/Nacked-by = rejected)
4. PR present in qcom-next: No — patch not found in qcom-next (searched 30 recent commits to shikra.dtsi by subject and diff fingerprint)

Verdict: N/A — click to expand

🔍 Patch Validation

PR: #804 - FROMLIST: arm64: dts: qcom: shikra: Add missing CPU OPPs
Upstream commit: https://lore.kernel.org/all/20260702-shikra-dt-m1-v5-4-f911ac92720c@oss.qualcomm.com/
Verdict: ⏭️ SKIPPED (network restrictions prevent lore.kernel.org access)

Commit Message

Check	Status	Note
Subject matches upstream	⏭️	Cannot fetch lore patch (network restricted)
Body preserves rationale	✅	Clear description of changes: adds 2.208 GHz OPP to both tables, 768 MHz to CPU3
Fixes tag present/correct	N/A	Not a fix; new feature addition
Authorship preserved	✅	From: matches lore author (Komal Bajaj); FROMLIST: allows submitter to differ
Backport note (if applicable)	N/A	FROMLIST: prefix correct for mailing list patch

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/shikra.dtsi	✅	Adds three new OPP entries: 2208 MHz (CPU0), 768 MHz + 2208 MHz (CPU3); label-free format consistent with e5898e9

Context Analysis

The PR patch builds on commit e5898e92cc25 ("arm64: dts: qcom: shikra: drop unused labels from OPP table entries") which removed per-node labels like cpu0_opp_768mhz. The current patch correctly follows that label-free convention for the new OPP entries.

Changes:

• CPU0 table: Adds opp-2208000000 (2.208 GHz)
• CPU3 table: Adds opp-768000000 (768 MHz) and opp-2208000000 (2.208 GHz)

All new entries follow the established pattern: opp-hz, opp-peak-kBps properties with correct formatting.

Upstream Patch Status

⏭️ Cannot verify — network access to lore.kernel.org is restricted in this environment. Manual verification required:

• Visit https://lore.kernel.org/all/20260702-shikra-dt-m1-v5-4-f911ac92720c@oss.qualcomm.com/
• Check for maintainer replies: applied, queued, Reviewed-by:, Acked-by: (acceptance) or NAK, Nacked-by: (rejection)
• Search torvalds/linux mainline: git log --grep="Add missing CPU OPPs" -- arch/arm64/boot/dts/qcom/shikra.dtsi

qcom-next Presence

⚠️ Not found in qcom-next — searched by subject ("Add missing CPU OPPs") and diff fingerprint (8b4edbb8e86d6aeebf39e5abd26544bd) against 30 recent commits touching shikra.dtsi. This patch has not landed in the Qualcomm kernel tree yet.

Issues

None detected in commit message structure or diff format. The patch is well-formed and consistent with the codebase style.

Verdict

Cannot complete full validation due to network restrictions preventing lore.kernel.org access. Based on available checks:

• ✅ Commit message is well-structured with clear rationale
• ✅ Authorship correct for FROMLIST: prefix
• ✅ Diff format consistent with recent qcom-next changes
• ⚠️ Not yet in qcom-next (expected for a FROMLIST: patch under review)
• ⏭️ Upstream status unknown (requires manual lore.kernel.org check)

Recommendation: Manually verify the lore thread status before merging. If the patch has received maintainer approval (Reviewed-by:, Acked-by:, or applied confirmation), it is safe to merge. If still under review or has received a NAK, hold until upstream decision is final.

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260702-shikra-dt-m1-v5-4-f911ac92720c@oss.qualcomm.com/
2. Lore link matches PR commits: Cannot verify — network restrictions prevent fetching upstream patch for comparison
3. Upstream patch status: Unknown — manual verification required at lore.kernel.org (check for maintainer replies: applied/queued/Reviewed-by/Acked-by = accepted; NAK/Nacked-by = rejected)
4. PR present in qcom-next: No — patch not found in qcom-next (searched 30 recent commits to shikra.dtsi by subject and diff fingerprint)

[qlijarvis]

PR #804 — checker-log-analyzer

PR: #804
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28660624804

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped - no binding changes
dtb-check	✅	DTB validation passed
sparse-check	⏭️	Skipped - no C/H file changes
check-uapi-headers	⏭️	Skipped - no UAPI changes
check-patch-compliance	❌	Content mismatch with upstream link
tag-check	✅	Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #804 - FROMLIST: arm64: dts: qcom: shikra: Add missing CPU OPPs
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28660624804

Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped - no binding changes
dtb-check	✅	DTB validation passed
sparse-check	⏭️	Skipped - no C/H file changes
check-uapi-headers	⏭️	Skipped - no UAPI changes
check-patch-compliance	❌	Content mismatch with upstream link
tag-check	✅	Subject has valid FROMLIST: prefix

---

❌ check-patch-compliance

Root cause: The patch content differs from the upstream version linked in the commit message — node labels have been removed.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Add missing CPU OPPs
Change is different from the one mentioned in Link

Analysis:

The PR patch removes DT node labels (e.g., cpu0_opp_768mhz:, cpu3_opp_1017mhz:) that are present in the upstream patch at:
https://lore.kernel.org/all/20260702-shikra-dt-m1-v5-4-f911ac92720c@oss.qualcomm.com/

Changes in PR patch:

• cpu0_opp_768mhz: opp-768000000 → opp-768000000
• cpu0_opp_1017mhz: opp-1017600000 → opp-1017600000
• cpu3_opp_1017mhz: opp-1017600000 → opp-1017600000
• (and similar for all other OPP nodes)

This is a legitimate adaptation — the node labels were likely removed because they are not referenced elsewhere in the downstream tree, making them unnecessary. However, the checker flags this as a content mismatch because it performs a strict diff comparison.

Fix options:

1. If the label removal is intentional (labels not used in downstream):

   • Add a note in the commit message explaining the adaptation:

     [ komal: removed unused node labels cpu0_opp_*mhz and cpu3_opp_*mhz
       as they are not referenced in the downstream tree ]
     

   • This documents the intentional deviation and makes it clear during review.

2. If you want to match upstream exactly:

   • Restore the node labels to match the upstream patch:

     git rebase -i <base_sha>   # mark commit as 'edit'
     # Edit arch/arm64/boot/dts/qcom/shikra.dtsi to restore labels
     git add arch/arm64/boot/dts/qcom/shikra.dtsi
     git commit --amend --no-edit
     git rebase --continue

Reproduce locally:

# Fetch the upstream patch
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260702-shikra-dt-m1-v5-4-f911ac92720c@oss.qualcomm.com/ -o /tmp/upstream

# Compare the diff content
diff <(git format-patch -1 2687167ad6b0313a4f398398f17a8d83720202fc --stdout | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/upstream/*.mbx | grep -E '^[+-][^+-]')

---

Verdict

1 non-blocking issue to address:

The check-patch-compliance failure is due to intentional label removal. This is a legitimate adaptation for the downstream tree, but should be documented in the commit message with a [ komal: ... ] note explaining why the labels were removed.

Recommendation: Add an adaptation note to the commit message, or restore the labels if you want to match upstream exactly. The functional change (adding the missing OPPs) is correct and all other checkers passed.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4593076 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4593076
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qcomlnxci]

Test Matrix

Test Case	hamoa-iot-evk	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3
BT_FW_KMD_Service	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
BT_ON_OFF	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
BT_SCAN	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
CPUFreq_Validation	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
CPU_affinity	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
DSP_AudioPD	◻️	⚠️ skip	◻️	⚠️ skip	✅ Pass	✅ Pass	✅ Pass
Ethernet	◻️	✅ Pass	◻️	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip
Freq_Scaling	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
GIC	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
IPA	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
Interrupts	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
OpenCV	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
PCIe	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
Probe_Failure_Check	◻️	❌ Fail	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail
RMNET	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
UFS_Validation	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
USBHost	◻️	❌ Fail	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail
WiFi_Firmware_Driver	◻️	❌ Fail	◻️	❌ Fail	❌ Fail	✅ Pass	✅ Pass
WiFi_OnOff	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
adsp_remoteproc	◻️	❌ Fail	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
cdsp_remoteproc	◻️	❌ Fail	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
gpdsp_remoteproc	◻️	❌ Fail	◻️	⚠️ skip	⚠️ skip	✅ Pass	✅ Pass
hotplug	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
irq	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
kaslr	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
pinctrl	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
qcom_hwrng	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
remoteproc	◻️	❌ Fail	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
rngtest	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
shmbridge	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
smmu	◻️	❌ Fail	◻️	❌ Fail	✅ Pass	✅ Pass	❌ Fail
watchdog	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass
wpss_remoteproc	◻️	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass

[qcomlnxci]

Test jobs on 2687167

• Job 152706 on hamoa-iot-evk
• Job 152708 on lemans-evk
• Job 152709 on monaco-evk
• Job 152705 on qcs615-ride
• Job 152710 on qcs6490-rb3gen2
• Job 152707 on qcs8300-ride
• Job 152703 on qcs9100-ride-r3