Merge wip #13
Merged
Merge wip #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbeaudoin0935
requested review from
bjordiscollaku,
sjakki88 and
vishwasudupa
as code owners
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
This is an artefact from when it was necessary to tun build.py with root permission because a chroot was created each time. Chroots are now reused, so root shall never be used anymore, therefore the output folders won't ever need to be chmod'ed anymore. Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Remove check_if_root() altogether. Root was only necessary when creating the chroot, and now the chroot is re-used every run so no need to create a new one each time. Also, the step of creating a chroot initially will be split into a separate script Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Chroot creation is now a dedicated command-line invokable script. This removes the need for ever having to use root to run the package creation If, and only if, the chroot does not already exist will root be necessary. It will also only be necessary for THIS script, and nothing else, which is much safer and prevents everything created to be owned by root which is anoying. Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Separating elements from the monolithic build.py Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Have the qcom-build-utils be cloned at the tip of the given ref during CI run to avoid having to propagate updates back up all the time. Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Now, when a function signature is changed, mark this change as incompatible, as it SHOULD be (what is wrong with the tool author...) Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
simonbeaudoin0935
force-pushed
the
sbeaudoi-wip
branch
from
84fcae2 to
b68a67b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge milestone work