audio: add overlay build environment setup for audioreach #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuppand
requested changes
Nov 26, 2025
Contributor
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
No audoireach - treats as base build, clean early return 0
audioreach present - do the overtlay DMA + pipewire setup and be strict
Runner/utils/audio_common.sh
Outdated
|
|
||
| setup_overlay_audio_environment() { | ||
| # Detect overlay build | ||
| if ! lsmod | grep -q audioreach; then |
Contributor
There was a problem hiding this comment.
use lsmod 2>/dev/null so it doesn't explode if lsmod behaves oddly. also use awk '$1 ~ /^audiorech/ ...' so it matches audioreach, audioreach_, etc.. on the module name column, not random strings in other coulmns.
Overlay builds using audioreach modules need special configuration before audio tests can run properly. Without this setup, PipeWire fails to communicate with the audio hardware. Changes: - Added setup_overlay_audio_environment() in audio_common.sh * Detects overlay builds via lsmod audioreach check * Sets /dev/dma_heap/system permissions (chmod 666) * Restarts pipewire service via systemctl * Waits up to 60s for service to be ready * Validates both process and wpctl communication - Integrated setup call in AudioPlayback and AudioRecord tests * Runs early, before backend detection * Fails test if setup fails on overlay builds * Zero overhead on base builds - Updated README files with overlay build documentation Signed-off-by: Teja Swaroop Moida <tmoida@qti.qualcomm.com>
Contributor
Author
|
I have updated the script as suggested. It now uses awk to match only the module name column with error suppression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlay builds using audioreach modules need special configuration before audio tests can run properly. Without this setup, PipeWire fails to communicate with the audio hardware.
Changes: