WiFi_Firmware_Driver: add ath10k support and improve validation #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend firmware scan and driver checks to handle ath10k in addition to ath11k. Detect SoC from DT model and choose appropriate firmware path dynamically. Verify active ath10k/ath11k kernel modules via lsmod for stronger validation. Switch to log_info/log_fail/log_pass flow for consistent functestlib usage. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
mwasilew
requested changes
Dec 8, 2025
Contributor
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
LGTM. I tested on all devices in the lab and all tests pass.
The only issue is the problem with functestlib.sh which wasn't changed here. Maybe it's a good idea to fix?
| case "$basename" in | ||
| wpss.mbn) | ||
| log_info "Platform using wpss.mbn firmware (e.g., Kodiak - WPSS via remoteproc)" | ||
| if validate_remoteproc_running "wpss"; then |
Contributor
There was a problem hiding this comment.
/lava-123035/0/tests/0_WiFi_Firmware_Driver/Runner/utils/functestlib.sh: line 1905: idx: command not found
https://lava.infra.foundries.io/scheduler/job/123035#L1948
Contributor
Author
There was a problem hiding this comment.
/lava-123035/0/tests/0_WiFi_Firmware_Driver/Runner/utils/functestlib.sh: line 1905: idx: command not foundhttps://lava.infra.foundries.io/scheduler/job/123035#L1948
3bfcc6a This commit addresses the missing idx by moving to the self-index logic.
Rework get_remoteproc_path_by_firmware() to iterate firmware files directly and read them without using cat. This avoids the bogus idx arithmetic that caused "operand expected" errors while still allowing callers to derive the remoteproc index from the returned path. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
mwasilew
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WiFi_Firmware_Drivertest to support ath10k in addition to ath11k./proc/device-tree/modeland pick appropriate firmware path dynamically./lib/firmware/ath11k/and/lib/firmware/ath10k/and verify presence/size.lsmodfor stronger driver validation.log_info/log_fail/log_passflow for consistent functestlib-style logging and exits.Testing