shellcheck: reduce false positives in performance scripts #354
Merged
vnarapar merged 5 commits intoqualcomm-linux:mainfrom Mar 22, 2026
Merged
shellcheck: reduce false positives in performance scripts #354vnarapar merged 5 commits intoqualcomm-linux:mainfrom
vnarapar merged 5 commits intoqualcomm-linux:mainfrom
Conversation
Remove earlier duplicate definitions of perf_is_number, perf_run_cmd_tee, and perf_sysbench_csv_append from Runner/utils/lib_performance.sh. These earlier copies were shadowed by later definitions in the same file, so this cleanup does not change runtime behavior after the library is sourced. The change only removes dead duplicate code and addresses newer ShellCheck SC2317 warnings. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Add a targeted SC2317 annotation for the trap-invoked cleanup function in Boot_Systemd_Validate/run.sh without changing runtime behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Add a targeted SC2317 annotation for the trap-invoked cleanup function in Runner/suites/Performance/Geekbench/run.sh without changing runtime behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Add a targeted SC2317 annotation for the trap-invoked cleanup function in Sysbench_Performance/run.sh without changing runtime behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Add a targeted SC2317 annotation for the trap-invoked cleanup function in Sysbench_Performance/run.sh without changing runtime behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address a small batch of ShellCheck warnings in performance scripts with no runtime behavior changes.
Changes included in this PR:
This is a lint-only cleanup to reduce CI noise from newer ShellCheck versions.