Skip to content

shellcheck: reduce false positives in Bluetooth scripts #357

Merged
vnarapar merged 2 commits intoqualcomm-linux:mainfrom
smuppand:Bluetooth-fix
Mar 23, 2026
Merged

shellcheck: reduce false positives in Bluetooth scripts #357
vnarapar merged 2 commits intoqualcomm-linux:mainfrom
smuppand:Bluetooth-fix

Conversation

@smuppand
Copy link
Copy Markdown
Contributor

This PR Address a small batch of ShellCheck warnings in Bluetooth scripts with no
runtime behavior changes.

Changes in this PR:

  • remove a shadowed duplicate bt_in_whitelist() helper from lib_bluetooth.sh
  • add a targeted SC2317 annotation for the trap-only cleanup function in
    BT_SCAN_PAIR/run.sh

Remove a shadowed duplicate definition of bt_in_whitelist() in
lib_bluetooth.sh to address ShellCheck SC2317 without changing behavior.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Add a targeted SC2317 annotation for the trap-invoked cleanup function in
BT_SCAN_PAIR/run.sh without changing runtime behavior.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
@smuppand smuppand requested review from abbajaj806 and vnarapar March 21, 2026 12:11
Copy link
Copy Markdown
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnarapar vnarapar merged commit 17e8a48 into qualcomm-linux:main Mar 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants