shellcheck: remove dead trailing completion logs in kernel run scripts#358
shellcheck: remove dead trailing completion logs in kernel run scripts#358vnarapar merged 1 commit intoqualcomm-linux:mainfrom
Conversation
smuppand
force-pushed
the
Kernel
branch
3 times, most recently
from
bd16408 to
2967158
Compare
Remove unreachable trailing completion log lines from kernel run.sh scripts where the final PASS/FAIL branches already exit unconditionally. This is a lint-only cleanup for SC2317 and does not change runtime behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
|
i think there are few changes added for other fixes aswell. please add a different commit for those or update the existing commit. Also i see fixes for SC2002 which is not mandatory and is just a optional rule. |
Ack. The additional fixes are still lint-only and adjacent to the same files being touched for SC2317, so I’d prefer to keep them together in this PR instead of splitting into more commits. There is no intended functional change.
Thanks for pointing this out. You’re right that SC2002 is an optional rule. Since I’ve already fixed those instances as part of the cleanup, I’d prefer to keep them for consistency and to avoid carrying forward known lint warnings. |
2 participants
This PR fixes the shellcheck reported issues by removing unreachable trailing completion log lines from kernel run.sh scripts where the final PASS/FAIL branches already exit unconditionally.
This is a lint-only cleanup for SC2317 and does not change runtime behavior.