Add: test script for validating Qualcomm HWRNG functionality #36
Conversation
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
Please update your signed-off-by to use first and last name.
@mwasilew In the latest commit, I expanded the last name and signed off, but the DCO Signed off check is failing. |
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
Please rebase this feature branch on top of latest main. This helps to review the PR easier and merge.
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
Please squash the commits
|
Rebased and Squashed all commits on this feature branch on top of latest main |
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
Code looks OK. The markdown file is missing copyright statement. Please fix the commiter email. This is what the automated checks are complaining about:
Invalid email for Committer: root@hu-naveenks-hyd.qualcomm.com
Set the email in the repository (or globally)
git config user.email your_email@address
git congig user.name "Your Name"
After that rewrite the commit
git commit --amend -s --reset-author
|
Thanks @mwasilew, Amended with changed committer email |
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
Please add Qualcomm's copyright to the .md file. I think this is the last missing bit
Done |
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
Few minor changes are required.
|
Amended with changes. |
nklazy
force-pushed
the
main
branch
2 times, most recently
from
6e87484 to
c140375
Compare
Runner/suites/Kernel/FunctionalArea/baseport/qcom_hwrng/README_qcom_hwrng.md
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/qcom_hwrng/README_qcom_hwrng.md
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/qcom_hwrng/README_qcom_hwrng.md
Outdated
Show resolved
Hide resolved
nklazy
force-pushed
the
main
branch
2 times, most recently
from
24bbd48 to
6fbb4aa
Compare
|
Done |
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
|
Please address the shell check failure |
|
Rebase to the latest and remove the directories(FunctionalArea) which are not required. |
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
|
@nklazy is this PR still required? |
Yes, will commit will latest changes. |
nklazy
force-pushed
the
main
branch
2 times, most recently
from
8f8e6a1 to
082be94
Compare
|
Amended with changes suggested |
- Added initial test script to validate Qualcomm HWRNG functionality - Refined script and documentation based on review feedback Signed-off-by: Naveenkumar Suresh <naveenks@qti.qualcomm.com>
|
Amended with changes suggested. |
4 participants
Adds initial test script and supporting documentation to validate qcom_hwrng integration and functionality.