shellcheck: fix trap-only cleanup false positives in kernel stress and userdata tests #360
Merged
vnarapar merged 2 commits intoqualcomm-linux:mainfrom Mar 22, 2026
Merged
shellcheck: fix trap-only cleanup false positives in kernel stress and userdata tests #360vnarapar merged 2 commits intoqualcomm-linux:mainfrom
vnarapar merged 2 commits intoqualcomm-linux:mainfrom
Conversation
Add a targeted SC2317 annotation for the trap-invoked cleanup function in UserDataEncryption/run.sh without changing runtime behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
…pptest Update Runner/suites/Kernel/Stress/Stressapptest/run.sh to: - replace the CPU_COUNT calculation with a shellcheck-clean form that preserves the intended counting of space-separated ONLINE_CPUS - add a targeted SC2317 annotation for the cleanup function invoked only through trap This is a mechanical cleanup and does not change the intended stressapptest flow. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small set of ShellCheck findings in two kernel test
scripts without changing runtime behavior.
What changed
function in:
function
preserves the intended counting of space-separated ONLINE_CPUS