shellcheck: fix cleanup, quoting, and dead trailing logs in CPU_affinity and Freq_Scaling#361
Merged
vnarapar merged 2 commits intoqualcomm-linux:mainfrom Mar 22, 2026
Merged
Conversation
Update Runner/suites/Kernel/Scheduler/CPU_affinity/run.sh to: - clean up the background task through an exit trap - quote TASK_PID in taskset and chrt calls - remove unreachable trailing lines after the final PASS/FAIL exit path This preserves the intended task cleanup behavior while addressing ShellCheck SC2086 and SC2317 findings. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Update Runner/suites/Kernel/DCVS/Freq_Scaling/run.sh to: - quote CPUFREQ_PATH when reading cpufreq sysfs files - remove the unreachable trailing completion log after the final PASS/FAIL exit path This is a mechanical ShellCheck cleanup and does not change the intended DCVS frequency scaling test flow. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small set of ShellCheck findings in two kernel scheduler/DCVS test scripts without changing their intended runtime behavior.
What changed
Runner/suites/Kernel/Scheduler/CPU_affinity/run.sh
Runner/suites/Kernel/DCVS/Freq_Scaling/run.sh