Gate quicinc emails via repo custom properties#11
Merged
quic-kaushikl merged 2 commits intoqualcomm:mainfrom Nov 4, 2025
Merged
Gate quicinc emails via repo custom properties#11quic-kaushikl merged 2 commits intoqualcomm:mainfrom
quic-kaushikl merged 2 commits intoqualcomm:mainfrom
Conversation
Contributor
quic-kaushikl
commented
Oct 29, 2025
quic-kaushikl
commented
This change updates the email checker to use '--commit-json' instead of '--json' when passing commit metadata. The rename improves clarity and avoids ambiguity as new options like '--properties-json' will be introduced in future updates. Key updates: - Modified 'check_email_pr.sh' to call 'check_email.sh' with '--commit-json'. - Updated 'check_email.sh' to replace all references to 'JSON' with 'COMMIT_JSON'. - Adjusted usage instructions and helper functions to reflect the new option name. This refactor prepares the codebase for upcoming enhancements that will read custom repository properties and pass them along to the email checker. Signed-off-by: Kaushik Lingarkar <kaushikl@qti.qualcomm.com>
quic-nasserg
requested changes
Oct 29, 2025
Collaborator
quic-nasserg
left a comment
quic-nasserg
left a comment
There was a problem hiding this comment.
Can you update the README too please?
Contributor
Author
Done |
quic-nasserg
requested changes
Oct 29, 2025
quic-nasserg
approved these changes
Nov 4, 2025
Allow '@quicinc.com' addresses based on repository custom properties so projects can explicitly opt in for specific roles (author or committer). Supported custom properties: - allow-quicinc-authors - allow-quicinc-committers Some repositories need to accept '@quicinc.com' emails, while others must continue blocking them. Using GitHub custom properties provides a repo-level toggle per role, eliminating hard-coded exceptions and making policy changes configurable. By default, '@quicinc.com' addresses are blocked unless the repository sets the appropriate property to 'true'. Signed-off-by: Kaushik Lingarkar <kaushikl@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.