Deprecate usage of github token#17
Merged
ynancher merged 2 commits intoqualcomm:mainfrom Mar 23, 2026
Merged
Conversation
|
Looks, good, Here you are making default as boolean true, and in the check_commits.py file you are accepting default as string |
58aee0b to
4773431
Compare
Contributor
Author
Thanks for pointing that out, have changed it to string by default to maintain consistency |
4773431 to
000dc86
Compare
abinjose-qualcomm
suggested changes
Mar 2, 2026
njjetha
reviewed
Mar 3, 2026
|
can you update commit-msg of this PR to provide more information on this change like why this is needed etc? |
quic-vpendy
reviewed
Mar 3, 2026
abinjose-qualcomm
suggested changes
Mar 11, 2026
Contributor
|
I see same changes being added/reverted between the two commits. Can you squash your changes? Or separate the changes logically in separate commits. |
3f6653d to
64171c4
Compare
quic-vpendy
reviewed
Mar 17, 2026
Uses repo checkout to get base and head commit of PR to support deprecation of github token Signed-off-by: Yashasvi Nancherla <ynancher@qti.qualcomm.com>
c6a220e to
ac76239
Compare
Signed-off-by: Yashasvi Nancherla <ynancher@qti.qualcomm.com>
njjetha
approved these changes
Mar 23, 2026
abinjose-qualcomm
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dependency on GitHub API tokens by switching to local Git
commands for commit retrieval and validation. This change improves
security and simplifies the action's setup process.
With this change, the workflow will treat both private repos and public
repos similarly and will work in the same way for both.