Skip to content

Deprecate usage of github token#17

Merged
ynancher merged 2 commits intoqualcomm:mainfrom
ynancher:ynancher-commit-msg-check-action
Mar 23, 2026
Merged

Deprecate usage of github token#17
ynancher merged 2 commits intoqualcomm:mainfrom
ynancher:ynancher-commit-msg-check-action

Conversation

@ynancher
Copy link
Copy Markdown
Contributor

@ynancher ynancher commented Feb 23, 2026

Remove dependency on GitHub API tokens by switching to local Git
commands for commit retrieval and validation. This change improves
security and simplifies the action's setup process.

With this change, the workflow will treat both private repos and public
repos similarly and will work in the same way for both.

@hasiburr-qti
Copy link
Copy Markdown

Looks, good,
One suggestion:

check-blank-line:
    required: false
    default: true
    description: "check for a blank line between commit title and body"

Here you are making default as boolean true, and in the check_commits.py file you are accepting default as string true, It would be better to maintain consistency.

@ynancher ynancher force-pushed the ynancher-commit-msg-check-action branch from 58aee0b to 4773431 Compare February 24, 2026 06:36
@ynancher
Copy link
Copy Markdown
Contributor Author

Looks, good, One suggestion:

check-blank-line:
    required: false
    default: true
    description: "check for a blank line between commit title and body"

Here you are making default as boolean true, and in the check_commits.py file you are accepting default as string true, It would be better to maintain consistency.

Thanks for pointing that out, have changed it to string by default to maintain consistency

@ynancher ynancher force-pushed the ynancher-commit-msg-check-action branch from 4773431 to 000dc86 Compare February 24, 2026 06:41
Comment thread README.md Outdated
Comment thread README.md
Comment thread check_commits.py Outdated
Comment thread check_commits.py
Comment thread action.yml Outdated
@quic-vpendy
Copy link
Copy Markdown

can you update commit-msg of this PR to provide more information on this change like why this is needed etc?

Comment thread tests/test_check_commits.py Outdated
Comment thread tests/test_check_commits.py Outdated
Comment thread tests/test_check_commits.py Outdated
Comment thread check_commits.py
Comment thread check_commits.py
Comment thread check_commits.py
Comment thread check_commits.py
Comment thread tests/test_check_commits.py
Comment thread action.yml
Comment thread check_commits.py Outdated
Comment thread action.yml
Comment thread action.yml
@abinjose-qualcomm
Copy link
Copy Markdown
Contributor

I see same changes being added/reverted between the two commits. Can you squash your changes? Or separate the changes logically in separate commits.

@ynancher ynancher force-pushed the ynancher-commit-msg-check-action branch from 3f6653d to 64171c4 Compare March 16, 2026 05:19
Comment thread check_commits.py Outdated
Comment thread check_commits.py Outdated
Comment thread check_commits.py Outdated
Comment thread check_commits.py Outdated
Comment thread check_commits.py
Uses repo checkout to get base
and head commit of PR to support
deprecation of github token

Signed-off-by: Yashasvi Nancherla <ynancher@qti.qualcomm.com>
@ynancher ynancher force-pushed the ynancher-commit-msg-check-action branch from c6a220e to ac76239 Compare March 17, 2026 10:45
Signed-off-by: Yashasvi Nancherla <ynancher@qti.qualcomm.com>
@ynancher ynancher merged commit e18102a into qualcomm:main Mar 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants