[RISCV][Xqci] Remove c.lui absolute relaxations #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenary
force-pushed
the
pr/remove-abs-c-lui-relax
branch
from
d9c0b7f to
8ff6009
Compare
Member
Author
|
This change is aiming for both mainline and 21.x release branch. I guess we put it on main and then backport it? |
lenary
requested review from
quic-akaryaki and
quic-seaswara
and removed request for
quic-akaryaki
lenary
force-pushed
the
pr/remove-abs-c-lui-relax
branch
2 times, most recently
from
bfa9601 to
da41b84
Compare
These are not valid, as we do not verify that the page-alignment that we checked for during relaxation will be preserved in the final object. Without these checks, we may end up creating a `c.lui` which cannot materialize the intended address, because the address is no longer aligned due to relaxation. Fixes qualcomm#455 Signed-off-by: Sam Elliott <aelliott@qti.qualcomm.com>
lenary
force-pushed
the
pr/remove-abs-c-lui-relax
branch
from
da41b84 to
0f9e955
Compare
quic-seaswara
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not valid, as we do not verify that the page-alignment that we checked for during relaxation will be preserved in the final object. Without these checks, we may end up creating a
c.luiwhich cannot materialize the intended address, because the address is no longer aligned due to relaxation.Fixes #455