Enhance session management, prompt navigation, and macOS shortcuts#327
Merged
Conversation
Enhance prompt navigation and session management features
Resolves two conflicts vs current master: - crates/jcode-provider-metadata/src/catalog.rs: LOGIN_PROVIDERS array length conflict between master's +4 providers (BigModel, Cohere, GitLab Duo, Vertex AI = 49) and PR #323's +1 (Anthropic API direct = 46). Final length: 50. - src/tui/app/state_ui_input_helpers.rs: Master appended dollar_token_tests module at EOF; PR #323 appended ExternalCliSuggestionCandidate + helpers. Both are end-of-file additions to disjoint scopes, kept both.
Every workflow run on master and recent branches has been failing at
startup with:
Invalid Argument - failed to parse workflow:
Unrecognized named-value: 'secrets'. Located at position 1 within
expression: secrets.DEPLOY_KEY != '' (Lines 30, 84, 126, 216, 388
in .github/workflows/ci.yml; Line 63 in .github/workflows/release.yml)
GitHub Actions' expression validator does not permit referencing the
`secrets` context inside an `if:` expression at step level in this
configuration — runs were being marked "completed/failure" with zero
jobs before any work could happen, so master CI has effectively been
non-functional.
Workaround: lift `secrets.DEPLOY_KEY` into a job-level `env:`
binding (`DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}`), then check
`env.DEPLOY_KEY != ''` in the step `if:`. The secret is still
accessed via `secrets.DEPLOY_KEY` inside `with:` blocks (which is
allowed). Behavior is unchanged when the secret is present or absent.
Applied to every job in ci.yml that uses webfactory/ssh-agent
(quality, mobile-simulator, build, windows-build-test,
windows-cross-check) and to release.yml's build-linux-macos job.
- Remove unused_mut (input.rs, turborag.rs) - Gate test-only functions with #[cfg(test)] (hash_window, active_at_token, suggest_at_path) - Fix ClipboardCommand visibility (private_interfaces warning) - Allow dead_code on AtPicker public API stubs kept for upcoming wiring - Fix unused variable _end in test assertions - Apply cargo clippy --fix for needless_borrow, manual_char_comparison, etc. - Fix manual_clamp in acp.rs - Fix doc_overindented_list_items in args.rs, terminal.rs - Replace vec_init_then_push with vec![] literal in export.rs - Allow too_many_arguments, enum_variant_names on anthropic.rs internals - Refresh code_size, test_size, panic, swallowed_error budget baselines
- Add #[allow(clippy::await_holding_lock)] to test fns that hold lock_test_env() across await (intentional test serialization) - Fix if_same_then_else in state_ui_input_helpers.rs (simplify redundant conditional to direct assignment)
…ets-context fix(ci): mirror DEPLOY_KEY into env to unblock workflow startup
Fix clippy lints, dead-code warnings, and refresh quality budgets
Merge PR #323 with conflicts resolved (macOS shortcuts + UI fixes)
quangdang46
merged commit c98470c
into
experimental/multi-agent-foundation
2 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.