fix: resolve 4 cross-package bugs causing test failures#11
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix renamed hook: re-export useDebounce as useSearchDebounce in api.ts - Fix Button component: pass through aria-label prop for accessibility - Fix DataTable: use functional state update to avoid stale closure bug - Fix date formatting: use d/MM/yyyy (non-padded day) format - Configure happy-dom preload for UI component tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 9 failing tests across 5 test files in this multi-package TypeScript monorepo.
Changes
apps/web/src/lib/api.ts— Fixed renamed hook import:useThrottle→useDebounce, re-exported asuseSearchDebouncepackages/ui/src/components/Button/Button.tsx— Pass througharia-labelprop for icon-only button accessibilitypackages/ui/src/components/DataTable/DataTable.tsx— Use functional state update to fix stale closure bug in sort handlerpackages/utils/src/format/date.ts— Used/MM/yyyy(non-padded day) format instead ofdd/MM/yyyybunfig.toml+packages/ui/bunfig.toml— Configure happy-dom preload for UI component testsVerification
bun test→ 13 pass, 0 failnpx tsc --noEmit→ only expectedbun:testmodule resolution errors in test files (no source code type errors)Assumptions
bun:testTypeScript module resolution errors are pre-existing and expected (requires@types/bunwhich is not in dependencies)[test] environmentin bunfig.toml