fix: resolve all failing tests across monorepo packages#17
Open
stooit wants to merge 1 commit into
Open
Conversation
- Add useSearchDebounce export alias in packages/utils (renamed hook) - Update apps/web/src/lib/api.ts to use useSearchDebounce instead of useThrottle - Fix Button component to pass through aria-label prop for accessibility - Fix DataTable stale closure bug using functional state update in sort handler - Fix date formatter to use non-padded day format (d/MM/yyyy) - Configure happy-dom preload in root bunfig.toml for DOM test environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSearchDebounceexport alias inpackages/utils(the hook was renamed touseDebouncebut consumers still referenced the old name)apps/web/src/lib/api.tsto importuseSearchDebounceinstead of the non-existentuseThrottlearia-labelprop for icon-only buttonsprev => ...) instead of capturing stale closure valuedd/MM/yyyytod/MM/yyyyto avoid zero-padding the dayhappy-dompreload in rootbunfig.tomlso DOM-dependent UI tests run correctly from workspace rootVerification
All 13 tests pass across 5 test files. TypeScript compilation is clean (only
bun:testmodule declaration warnings in test files, which are expected).Assumptions
bun:testTypeScript errors are expected and do not affect runtime — bun resolves these internallyd/MM/yyyy) matches the test expectation of output starting with "1" for March 1sthappy-dompreload at root level is the correct approach for bun workspace test runs