fix: resolve all failing tests and type errors across monorepo#6
Open
stooit wants to merge 1 commit into
Open
Conversation
- Re-export useDebounce as useSearchDebounce and useThrottle in packages/utils - Fix Button component to pass through aria-label prop for accessibility - Fix DataTable stale closure bug using functional state update in sort handler - Fix date formatting to use non-zero-padded day format (d/MM/yyyy) - Configure bunfig.toml to use happy-dom preload for DOM test environment - Add bun-types to tsconfig for bun:test module resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useDebounceinpackages/utilsis now also exported asuseSearchDebounceanduseThrottleto fix broken imports inapps/webaria-labelprop through to the rendered element, satisfying the icon-only button accessibility testprev => ...) to avoid capturing stale sort directiondd/MM/yyyytod/MM/yyyyto produce non-zero-padded day output (e.g., "1/03/2024")bunfig.tomlto preloadhappy-dom/globalso@testing-library/reacthas access todocumentbun-typesto tsconfigtypesarray forbun:testmodule resolutionVerification
All 13 tests pass across 5 files. Zero TypeScript errors from
tsc --noEmit.Assumptions
bun:testtype errors needed fixing (added already-installedbun-typesto tsconfig)useSearchDebounceanduseThrottleare aliases for the existinguseDebouncehook