fix: resolve cross-package bugs causing test failures#9
Open
stooit wants to merge 1 commit into
Open
Conversation
- Rename useThrottle import to useDebounce in apps/web/src/lib/api.ts and add useSearchDebounce re-export from @e2e/utils - Add jsdom test environment config in bunfig.toml for UI package tests - Forward aria-label prop in Button component for accessibility - Fix stale closure in DataTable sort handler using functional state update - Correct date format string to use day without leading zero (d/MM/yyyy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 cross-package bugs that caused 9 test failures across the monorepo:
apps/web/src/lib/api.tsimporteduseThrottlewhich was renamed touseDebouncein@e2e/utils; also addeduseSearchDebouncere-export that tests expectjsdomtest environment inbunfig.tomlso@testing-library/reacttests have a DOMaria-labelprop inButtoncomponent for icon-only button accessibilitydd/MM/yyyytod/MM/yyyy(day without leading zero)Verification
All 13 tests pass, 0 failures. TypeScript source files compile cleanly (
npx tsc --noEmitonly reports missingbun:testtype declarations in test files, which is expected).Assumptions
bun:testmodule type declaration errors in test files are pre-existing and not in scope (we cannot modify test files or add dependencies)useSearchDebounceexport is a thin wrapper re-exportinguseDebounceunder the name the consuming app expects