Improve rereview prompting and add force full review #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git diff may fail in GitHub Actions shallow clones - provide gh api and gh pr diff as fallback options
agent was adding all PR files to todos before checking if this was a re-review. now explicitly instructs to determine scope first, then create todos only for files in that scope.
- previous comments are already provided in context, no need to fetch - todo list scope depends on first-time vs re-review status - add guidance to use rg for searching context based on comments/diff - remove contradictory "review EVERY file" language
…commits" the diff should be from the previous review commit SHA to current HEAD, capturing ALL changes since the bot last reviewed regardless of commit count
if diff is empty, complete immediately with verdict NONE
- new action input: force_full_review (default: false) - when enabled, ignores re-review optimizations and reviews all files - also handle edge case of empty diff since last review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Adds a force_full_review input and threads it through TriggerContext/env so the agent can be instructed to ignore re-review scoping and do a full pass. Prompt updates clarify first-review vs re-review scope and reduce redundant comment fetching. No functional issues found; changes are consistent and should be backward compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
force_full_reviewinput and improve re-review prompting so the agent can optionally perform a full PR review even during re-review runs.Changes
force_full_reviewGitHub Action input